From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn()
Date: Wed, 9 Nov 2022 13:26:47 +0200 [thread overview]
Message-ID: <Y2uOd+mCwmh4qdm8@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gxM80EKiiMJKkN6t1CVgf1=6yYA3D4=TfOHVh1chaJuw@mail.gmail.com>
On Wed, Nov 09, 2022 at 12:12:03PM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 9, 2022 at 11:51 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Replace printk(KERN_WARNING) by pr_warn().
> >
> > While at it, use %pa for the resource_size_t variables.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This is Greg's stuff I think.
OK.
...
> > + resource_size_t end = addr + size - 1;
>
> And this change could be mentioned in the changelog too.
And it's (indirectly). This is to have a variable to be consistent in the
print. But I can add more explicit mention.
Thank you for a review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-09 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 10:51 [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn() Andy Shevchenko
2022-11-09 10:51 ` [PATCH v1 2/2] resource: Convert DEFINE_RES_NAMED() to be compound literal Andy Shevchenko
2022-11-09 11:14 ` Rafael J. Wysocki
2022-11-09 11:12 ` [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn() Rafael J. Wysocki
2022-11-09 11:26 ` Andy Shevchenko [this message]
2022-11-09 13:37 ` Greg Kroah-Hartman
2022-11-09 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2uOd+mCwmh4qdm8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox