From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes
Date: Wed, 9 Nov 2022 15:11:17 +0200 [thread overview]
Message-ID: <Y2um9emkYeYP0ZZM@smile.fi.intel.com> (raw)
In-Reply-To: <5640233.DvuYhMxLoT@kreacher>
On Wed, Nov 09, 2022 at 01:05:13PM +0100, Rafael J. Wysocki wrote:
> Hi All,
>
> This is a v2 of the series previously posted as
>
> https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/
>
> The first three patches in the series have not changed since then (I have
> considered moving the last patch, which is a fix, to the front, but that turns
> out to be a bit cumbersome and not really worth the effort).
>
> This series of patches does some assorted ACPI-related cleanups to the CMOS RTC
> driver:
> - redundant static variable is dropped,
> - code duplication is reduced,
> - code is relocated so as to drop a few unnecessary forward declarations of
> functions,
> - functions are renamed to avoid confusion,
> and fixes up an issue in the driver removal path.
LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-09 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 12:05 [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes Rafael J. Wysocki
2022-11-09 12:07 ` [PATCH v2 1/5] rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe() Rafael J. Wysocki
2022-11-09 12:09 ` [PATCH v2 2/5] rtc: rtc-cmos: Call rtc_wake_setup() " Rafael J. Wysocki
2022-11-09 12:09 ` [PATCH v2 3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions Rafael J. Wysocki
2022-11-09 12:12 ` [PATCH v2 4/5] rtc: rtc-cmos: Rename ACPI-related functions Rafael J. Wysocki
2022-11-09 12:15 ` [PATCH v2 5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal Rafael J. Wysocki
2022-11-09 13:11 ` Andy Shevchenko [this message]
2022-11-10 12:00 ` [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes Zhang Rui
2022-11-15 20:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2um9emkYeYP0ZZM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox