* Re: [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST [not found] ` <20221211231435.43c4f361@endymion.delvare> @ 2022-12-12 7:59 ` Uwe Kleine-König 2022-12-12 9:24 ` Andy Shevchenko 0 siblings, 1 reply; 2+ messages in thread From: Uwe Kleine-König @ 2022-12-12 7:59 UTC (permalink / raw) To: Jean Delvare Cc: Sean Young, Mauro Carvalho Chehab, Thierry Reding, linux-media, linux-kernel, linux-pwm, Rafael J. Wysocki, Len Brown, linux-acpi, Andy Shevchenko [-- Attachment #1: Type: text/plain, Size: 1375 bytes --] Hello, [expanded Cc: for the acpi topic] On Sun, Dec 11, 2022 at 11:14:35PM +0100, Jean Delvare wrote: > Hallo Uwe, > > On Sun, 11 Dec 2022 21:56:48 +0100, Uwe Kleine-König wrote: > > On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote: > > > --- linux-6.0.orig/drivers/media/rc/pwm-ir-tx.c > > > +++ linux-6.0/drivers/media/rc/pwm-ir-tx.c > > > @@ -120,7 +120,7 @@ static struct platform_driver pwm_ir_dri > > > .probe = pwm_ir_probe, > > > .driver = { > > > .name = DRIVER_NAME, > > > - .of_match_table = of_match_ptr(pwm_ir_of_match), > > > + .of_match_table = pwm_ir_of_match, > > > }, > > > }; > > > module_platform_driver(pwm_ir_driver); > > > > That hunk makes sense even without the Kconfig change. ACPI makes use of > > .of_match_table, so > > > > .of_match_table = of_match_ptr(pwm_ir_of_match), > > > > is (almost?) always wrong. > > Should we just get rid of this macro altogether then? > > (Somehow I have a strange feeling that we already had this > discussion...) Might be. But for me this is only second hand knowledge, too. Maybe someone of the new recipents in this thread feels competent to comment here?! Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST 2022-12-12 7:59 ` [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST Uwe Kleine-König @ 2022-12-12 9:24 ` Andy Shevchenko 0 siblings, 0 replies; 2+ messages in thread From: Andy Shevchenko @ 2022-12-12 9:24 UTC (permalink / raw) To: Uwe Kleine-König Cc: Jean Delvare, Sean Young, Mauro Carvalho Chehab, Thierry Reding, linux-media, linux-kernel, linux-pwm, Rafael J. Wysocki, Len Brown, linux-acpi On Mon, Dec 12, 2022 at 08:59:07AM +0100, Uwe Kleine-König wrote: > On Sun, Dec 11, 2022 at 11:14:35PM +0100, Jean Delvare wrote: > > On Sun, 11 Dec 2022 21:56:48 +0100, Uwe Kleine-König wrote: > > > On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote: ... > > > > - .of_match_table = of_match_ptr(pwm_ir_of_match), > > > > + .of_match_table = pwm_ir_of_match, > > > That hunk makes sense even without the Kconfig change. ACPI makes use of > > > .of_match_table, so > > > > > > .of_match_table = of_match_ptr(pwm_ir_of_match), > > > > > > is (almost?) always wrong. > > > > Should we just get rid of this macro altogether then? > > > > (Somehow I have a strange feeling that we already had this > > discussion...) > > Might be. But for me this is only second hand knowledge, too. Maybe > someone of the new recipents in this thread feels competent to comment > here?! Pros of of_match_ptr() / ACPI_PTR(): - saves a few dozens of bytes in the module ID tables - doesn't show ACPI ID for non-ACPI platform or OF ID on non-OF platforms Cons: - prevents from using OF IDs on ACPI platforms - doesn't show ACPI ID for non-ACPI platform or OF ID on non-OF platforms - makes error prone for the compiler to have the variable unused - makes code uglier (I left the second in the both because I find useful to have all supported IDs to be listed even if the system is compiled with OF/ACPI opted-out.) Personally I remove the of_match_ptr()/ACPI_PTR() from drivers that can be used on OF or ACPI platforms, which leaves us only with the drivers we are 100% sure that they won't ever be used on non-OF platforms. BUT, I do not see any sense to have of_match_ptr() that either in use, because the driver in question is 100% for OF platform, or not when it's compile tested, which means it reduces test coverage anyway. All the same for ACPI_PTR(). TL;DR: I don't see any [big] usefulness of keeping those macros. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221121170911.7cd72bfc@endymion.delvare>
[not found] ` <20221211205648.hdv5haufqwfoxzu2@pengutronix.de>
[not found] ` <20221211231435.43c4f361@endymion.delvare>
2022-12-12 7:59 ` [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST Uwe Kleine-König
2022-12-12 9:24 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox