From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
djrscally@gmail.com, heikki.krogerus@linux.intel.com,
sakari.ailus@linux.intel.com, rafael@kernel.org
Subject: Re: [PATCH v3] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()
Date: Wed, 28 Dec 2022 10:46:12 +0100 [thread overview]
Message-ID: <Y6wQZOn+fObx0Mua@kroah.com> (raw)
In-Reply-To: <Y6wOS8NFAZc5+piJ@smile.fi.intel.com>
On Wed, Dec 28, 2022 at 11:37:15AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 23, 2022 at 10:25:42AM +0800, Yang Yingliang wrote:
> > The 'parent' returned by fwnode_graph_get_port_parent()
> > with refcount incremented when 'prev' is not NULL, it
> > needs be put when finish using it.
> >
> > Because the parent is const, introduce a new variable to
> > store the returned fwnode, then put it before returning
> > from fwnode_graph_get_next_endpoint().
>
> Rafael, Greg, is this went through the cracks?
Yes, but still in my queue. I'll look at it when I get back from break.
thanks,
greg k-h
next prev parent reply other threads:[~2022-12-28 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 2:25 [PATCH v3] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint() Yang Yingliang
2022-11-23 13:31 ` Andy Shevchenko
2022-11-25 9:32 ` Daniel Scally
2022-11-25 9:49 ` Yang Yingliang
2022-11-25 9:59 ` Sakari Ailus
2022-11-25 15:50 ` Daniel Scally
2022-12-28 9:37 ` Andy Shevchenko
2022-12-28 9:46 ` Greg KH [this message]
2022-12-28 9:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wQZOn+fObx0Mua@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox