From: Borislav Petkov <bp@alien8.de>
To: James Puthukattukaran <james.puthukattukaran@oracle.com>
Cc: linux-acpi@vger.kernel.org, x86@kernel.org, rafael@kernel.org,
lenb@kernel.org, mingo@redhat.com, tglx@linutronix.de,
hpa@zytor.com
Subject: Re: [PATCH v3] x86/ACPI: Ignore CPUs that are not online capable for x2apic, entries as well
Date: Wed, 11 Jan 2023 00:24:01 +0100 [thread overview]
Message-ID: <Y73zkXlPqiMFeT6V@zn.tnic> (raw)
In-Reply-To: <1987c2d2-1246-b172-985f-360e5c2c437a@oracle.com>
On Tue, Jan 10, 2023 at 05:43:41PM -0500, James Puthukattukaran wrote:
> Adding others that I missed on my first email.
>
> James
>
> On 12/22/22 13:26, James Puthukattukaran wrote:
> > Extending commit aa06e20f1be6 ("x86/ACPI: Don't add CPUs that are not
> > online capable") to include acpi_parse_x2apic as well.
This doesn't look like an extension to some existing commit but like a separate
fix.
> > There is a check for invalid apicid; however, there are BIOS FW with madt
> > version >= 5 support that do not bother setting apic id to an invalid value
> > since they assume the OS will check the enabled and online capable flags.
Which BIOSes are those?
Also, I'm no BIOS guy but I don't see you checking MADT version anywhere?
> > Signed-off-by: James Puthukattukaran<james.puthukattukaran@oracle.com>
> > Reported-by: Benjamin Fuller<ben.fuller@oracle.com>
> >
> > v2 : use 'enabled' local variable. Also fix checkpatch.pl catches
> > v3 : updates as per Rafael's comments
Yah, I'd like for Rafael to decide what to do here...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-10 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 18:26 [PATCH v3] x86/ACPI: Ignore CPUs that are not online capable for x2apic, entries as well James Puthukattukaran
2023-01-10 22:43 ` James Puthukattukaran
2023-01-10 23:24 ` Borislav Petkov [this message]
2023-01-11 9:48 ` Rafael J. Wysocki
2023-01-11 9:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y73zkXlPqiMFeT6V@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=james.puthukattukaran@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox