Re: [net-next: PATCH v4 4/8] net: mvpp2: initialize port fwnode pointer

Andy Shevchenko
2023-01-16T18:16:21Z

On Mon, Jan 16, 2023 at 06:34:16PM +0100, Marcin Wojtas wrote:
> As a preparation to switch the DSA subsystem from using
> of_find_net_device_by_node() to its more generic fwnode_ equivalent,
> and later to allow ACPI description, update the port's device structure
> also with its fwnode pointer.

I believe this patch worth to be submitted even before core of this series.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 5f89fcec07b1..a25e90791700 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -6884,7 +6884,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
> dev->min_mtu = ETH_MIN_MTU;
> /* 9704 == 9728 - 20 and rounding to 8 */
> dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
> - dev->dev.of_node = port_node;
> + device_set_node(&dev->dev, port_fwnode);
>
> port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
> port->pcs_xlg.ops = &mvpp2_phylink_xlg_pcs_ops;
> --
> 2.29.0
>

--
With Best Regards,
Andy Shevchenko