From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14CBC63797 for ; Tue, 17 Jan 2023 15:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231233AbjAQPaO (ORCPT ); Tue, 17 Jan 2023 10:30:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233489AbjAQP36 (ORCPT ); Tue, 17 Jan 2023 10:29:58 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5358230EBF; Tue, 17 Jan 2023 07:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673969398; x=1705505398; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XxwipVAWmJahkeSSitKzk+AnKlTFXO268/T6NIHA6o8=; b=djATvUziNWaiB9bxexKCpHGChtP8ZV6RIEYHpTiEi5j6S6bLkV17nsiN iAZYh6mNPViPvxbWQFf0o+uhXdRQ8rd/Bk0fVetz+S/HZdbw8uKcxCA+F KkfIyrwQerjcRycuNuhqHuth6eiuYdHgiBwtzndBsdP2iBYdP3p7mK9mL VHjv2JMfDMPWbGO4JKcYMGXr4AnPSQcAURZaxmEZSEhn/QR4D0VUAHhqM uQdYQIc2AlqVtmnobxo2e9JLUovZuUJN0bZLUrJdF4Xd6/khbQsr+gURZ SCE6QSYsFXmOKjH1gJr7LhGD7Ai+/w5/hcZB1Szsn+rXp7sbxqbpmaTl0 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="410958474" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="410958474" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 07:29:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="783270861" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="783270861" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 17 Jan 2023 07:29:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pHnuM-00AdWl-2y; Tue, 17 Jan 2023 17:29:54 +0200 Date: Tue, 17 Jan 2023 17:29:54 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, rafael@kernel.org, linux-media@vger.kernel.org, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix Message-ID: References: <20230117122244.2546597-1-sakari.ailus@linux.intel.com> <20230117122244.2546597-8-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117122244.2546597-8-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jan 17, 2023 at 02:22:43PM +0200, Sakari Ailus wrote: > For all _DSD properties, skip going through the MIPI DisCo for Imaging > property name substitution table if the property doesn't have "mipi-img-" > prefix. ... > +#define MIPI_IMG_PREFIX "mipi-img-" I don't think this is good for readability. ... > + if (memcmp(elements[0].string.pointer, MIPI_IMG_PREFIX, > + sizeof(MIPI_IMG_PREFIX) - 1)) str_has_prefix() > + return; -- With Best Regards, Andy Shevchenko