Re: [PATCH 1/8] ACPI: property: Parse data node string references in properties

Andy Shevchenko
2023-01-17T14:31:16Z

On Tue, Jan 17, 2023 at 02:22:37PM +0200, Sakari Ailus wrote:
> Add support for parsing property references using strings, besides
> reference objects that were previously supported. This allows also
> referencing data nodes which was not possible with reference objects.

...

> + pr_err("ACPI: bad node type\n");

Looking at this I'm wondering what prevents us to have pr_fmt() defined as
it's done in ~60 modules under drivers/acpi already.

Other than that, LGTM.

--
With Best Regards,
Andy Shevchenko