Re: [PATCH 2/8] ACPI: property: Parse _CRS CSI-2 descriptor

Sakari Ailus
2023-01-19T14:12:01Z

Hi Andy,

On Tue, Jan 17, 2023 at 04:34:17PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 17, 2023 at 02:22:38PM +0200, Sakari Ailus wrote:
> > Parse newly added ACPI _CRS CSI-2 descriptor for CSI-2 and camera
> > configuration. For now, only figure out where the descriptor is present in
> > order to allow adding information from it to related devices.
>
> ...
>
> > +/*
> > + * MIPI DisCo for Imaging support.
> > + *
> > + * Copyright (C) 2022 Intel Corporation
>
> 2023?

Yes.

>
> > + */
>
> ...
>
> > +#include <linux/acpi.h>
> > +#include <linux/module.h>
>
> > +#include <linux/kernel.h>
>
> Not sure why you need this one instead of corresponding types.h and might be a
> few others (seems list.h, string.h at least).

Good catch.

I'll fix these for v2.

>
> > +#include <linux/overflow.h>
> > +#include <linux/slab.h>
> > +#include <linux/sort.h>

--
Sakari Ailus