From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FE0C677F1 for ; Tue, 17 Jan 2023 14:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232501AbjAQOfp (ORCPT ); Tue, 17 Jan 2023 09:35:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232557AbjAQOfX (ORCPT ); Tue, 17 Jan 2023 09:35:23 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88CB63EFE6; Tue, 17 Jan 2023 06:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673966116; x=1705502116; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HNMnGpnGaj1VF+Aiwv/vzdZKqavF6q+jFpmzcTCad7Q=; b=RNmVah9R4EcZNzCk4HZ/GdNCa9WHvzRm52VuPe50Queeewphgm8SHZaf 6B1h16Y++6wota2mcPF7BxaswRhzDhpLfkML298g9668DnMYdTLq8qBJq PGu1vbFNR5CokK7ZSIT+NWupDIQcEkBSsnlWWpp9ZW0vY0V0nhlUmtvpk lrzYk5xFVaLh49v72IlE3BAZmXGlplrzPfEQh03RGIP8n+R8dRev2MWHo SYk5XvGrZh0lMwJbodytU7FyzLZExEvIMu4CiTO+LZeXiQXO9glkk32bj ewPPpgCnTruh1SVHcdOaHTg/oHyNg3ZgDcDpiLRF6nxeLlQfqEnU2RKbd A==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="325982384" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="325982384" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 06:35:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="652568298" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="652568298" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 17 Jan 2023 06:35:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pHn3P-00AcEm-0O; Tue, 17 Jan 2023 16:35:11 +0200 Date: Tue, 17 Jan 2023 16:35:10 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, rafael@kernel.org, linux-media@vger.kernel.org, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 3/8] device property: Add SOFTWARE_NODE() macro for defining software nodes Message-ID: References: <20230117122244.2546597-1-sakari.ailus@linux.intel.com> <20230117122244.2546597-4-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117122244.2546597-4-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jan 17, 2023 at 02:22:39PM +0200, Sakari Ailus wrote: > Add SOFTWARE_NODE() macro in order to make defining software nodes look > nicer. This is analogous to different PROPERTY_ENTRY_*() macros for > defining properties. ... > +#define SOFTWARE_NODE(_name_, _properties_, _parent_) \ > + (struct software_node) { \ > + .name = _name_, \ > + .properties = _properties_, \ > + .parent = _parent_, \ Missed parentheses? > + } Otherwise LGTM. -- With Best Regards, Andy Shevchenko