Re: [PATCH v1 1/1] device property: Make fwnode_graph_for_each_endpoint() consistent

Rafael J. Wysocki
2023-01-18T19:55:47Z

On Tue, Jan 17, 2023 at 4:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Make fwnode_graph_for_each_endpoint() consistent with the rest of
> for_each_*() definitions in the file, i.e. use the form of
>
> for (iter = func(NULL); iter; \
> iter = func(iter))
>
> as it's done in all the rest of the similar macro definitions.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

and I think that you need to resend it and CC Greg (who picks up
device property patches nowadays).

> ---
> include/linux/property.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 37179e3abad5..f090419818a2 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -436,9 +436,9 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
> unsigned int fwnode_graph_get_endpoint_count(struct fwnode_handle *fwnode,
> unsigned long flags);
>
> -#define fwnode_graph_for_each_endpoint(fwnode, child) \
> - for (child = NULL; \
> - (child = fwnode_graph_get_next_endpoint(fwnode, child)); )
> +#define fwnode_graph_for_each_endpoint(fwnode, child) \
> + for (child = fwnode_graph_get_next_endpoint(fwnode, NULL); child; \
> + child = fwnode_graph_get_next_endpoint(fwnode, child))
>
> int fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode,
> struct fwnode_endpoint *endpoint);
> --