From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB350C6379F for ; Thu, 19 Jan 2023 15:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbjASPsP (ORCPT ); Thu, 19 Jan 2023 10:48:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbjASPrz (ORCPT ); Thu, 19 Jan 2023 10:47:55 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB1887670; Thu, 19 Jan 2023 07:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674143232; x=1705679232; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WDq3PaWr838vW+P+WF80t5tJts1I6f8G8mSMYofwq0U=; b=fql269gJKuvCV83T1iGlOYh+r4lEBH4gFD8TggWaQqK9UmEUvYPr8mFc TUw4JIyYrLtH23rHPT4LQnxwTeSS4h0nPBXXt95hvALBaMTA2zCD7ieSg geK15+nQtoxwrZyLz4p5ZM6ZNy3/y+zel1cw1WEs1dkNoNAPB6FyTMdJv 41gI44WYLJgSl55/G4W3d2tihWkWm7/P+Rbq4dHIsTM6plCaaE6glNmGQ hhU2gUuidibjOigXRyod2F6Wwogderw7fQntHQMFfph9ZC/kUX9x3Gsb7 8icybQGTtPvnNiBCFIJtkkoalA7BZI4+7AJHAiGzl1HA1aMbA2kr+OBpz g==; X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="326599993" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="326599993" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 07:47:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="692461970" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="692461970" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 19 Jan 2023 07:47:01 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pIX7z-00Bjgz-24; Thu, 19 Jan 2023 17:46:59 +0200 Date: Thu, 19 Jan 2023 17:46:59 +0200 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , Heikki Krogerus , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Sakari Ailus Subject: Re: [PATCH v4 1/4] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*() Message-ID: References: <20221122133600.49897-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 19, 2023 at 04:40:53PM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 23, 2022 at 07:55:44PM +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 22, 2022 at 2:35 PM Andy Shevchenko > > wrote: > > > > > > First of all, _ELEMENT_SIZE() repeats existing sizeof_field() macro. > > > Second, usage of _ARRAY_ELSIZE_LEN() adds unnecessary indirection > > > to the data layout. It's more understandable when the data structure > > > is placed explicitly. That said, get rid of those macros by replacing > > > them with the existing helper and explicit data structure layout. > > > > > > Signed-off-by: Andy Shevchenko > > > Acked-by: Heikki Krogerus > > > > The series in which this patch is included does not apply cleanly for me. > > > > I guess it depends on the earlier material already in Greg's tree, so > > I'm leaving it to Greg. > > Andy, did I miss this? Nope, thanks! 40eb28dc17f8 ("device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*()") -- With Best Regards, Andy Shevchenko