From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, rafael@kernel.org,
linux-media@vger.kernel.org, heikki.krogerus@linux.intel.com
Subject: Re: [PATCH 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix
Date: Thu, 19 Jan 2023 15:51:33 +0000 [thread overview]
Message-ID: <Y8lnBeamT90z4aKY@paasikivi.fi.intel.com> (raw)
In-Reply-To: <Y8a+8q5hzkoPjpDO@smile.fi.intel.com>
Hi Andy,
On Tue, Jan 17, 2023 at 05:29:54PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 17, 2023 at 02:22:43PM +0200, Sakari Ailus wrote:
> > For all _DSD properties, skip going through the MIPI DisCo for Imaging
> > property name substitution table if the property doesn't have "mipi-img-"
> > prefix.
>
> ...
>
> > +#define MIPI_IMG_PREFIX "mipi-img-"
>
> I don't think this is good for readability.
It should be used at least below, where it is referred twice.
I'm open to removing this from the table though.
>
> ...
>
> > + if (memcmp(elements[0].string.pointer, MIPI_IMG_PREFIX,
> > + sizeof(MIPI_IMG_PREFIX) - 1))
>
> str_has_prefix()
str_has_prefix() calls strlen() on prefix on every call. sizeof() will
generate much less code --- it's just a number.
>
> > + return;
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-01-19 15:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 12:22 [PATCH 0/8] ACPI _CRS CSI-2 and MIPI DisCo for Imaging support Sakari Ailus
2023-01-17 12:22 ` [PATCH 1/8] ACPI: property: Parse data node string references in properties Sakari Ailus
2023-01-17 14:29 ` Andy Shevchenko
2023-01-19 14:03 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 2/8] ACPI: property: Parse _CRS CSI-2 descriptor Sakari Ailus
2023-01-17 14:34 ` Andy Shevchenko
2023-01-19 14:04 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 3/8] device property: Add SOFTWARE_NODE() macro for defining software nodes Sakari Ailus
2023-01-17 14:35 ` Andy Shevchenko
2023-01-17 14:37 ` Andy Shevchenko
2023-01-17 14:37 ` Andy Shevchenko
2023-01-17 12:22 ` [PATCH 4/8] ACPI: property: Generate camera swnodes for ACPI and DisCo for Imaging Sakari Ailus
2023-01-17 14:59 ` Andy Shevchenko
2023-01-19 15:03 ` Sakari Ailus
2023-01-19 15:44 ` Andy Shevchenko
2023-01-23 11:15 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 5/8] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS Sakari Ailus
2023-01-17 15:22 ` Andy Shevchenko
2023-01-19 15:40 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 6/8] ACPI: property: Rename parsed MIPI DisCo for Imaging properties Sakari Ailus
2023-01-17 15:27 ` Andy Shevchenko
2023-01-19 15:45 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix Sakari Ailus
2023-01-17 15:29 ` Andy Shevchenko
2023-01-19 15:51 ` Sakari Ailus [this message]
2023-01-19 16:09 ` Andy Shevchenko
2023-01-19 16:11 ` Andy Shevchenko
2023-01-20 12:07 ` Sakari Ailus
2023-01-20 13:59 ` Andy Shevchenko
2023-01-20 11:58 ` Sakari Ailus
2023-01-20 15:11 ` Andy Shevchenko
2023-01-20 22:34 ` Sakari Ailus
2023-01-17 12:22 ` [PATCH 8/8] ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support Sakari Ailus
2023-01-17 15:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lnBeamT90z4aKY@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox