From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org,
rafael@kernel.org, heikki.krogerus@linux.intel.com
Subject: Re: [PATCH v2 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix
Date: Tue, 24 Jan 2023 18:41:14 +0200 [thread overview]
Message-ID: <Y9AKKlqx7qbkQMuS@smile.fi.intel.com> (raw)
In-Reply-To: <Y8//GN6Eud77cicF@kekkonen.localdomain>
On Tue, Jan 24, 2023 at 05:54:00PM +0200, Sakari Ailus wrote:
> On Mon, Jan 23, 2023 at 05:27:46PM +0200, Andy Shevchenko wrote:
> > On Mon, Jan 23, 2023 at 03:46:16PM +0200, Sakari Ailus wrote:
...
> > > - { "mipi-img-lens-focus", "lens-focus" },
> > > - { "mipi-img-flash-leds", "flash-leds" },
> > > - { "mipi-img-clock-frequency", "clock-frequency" },
> > > - { "mipi-img-led-max-current", "led-max-microamp" },
> > > - { "mipi-img-flash-max-current", "flash-max-microamp" },
> > > - { "mipi-img-flash-max-timeout", "flash-max-timeout-us" },
> > > + { MIPI_IMG_PREFIX "lens-focus", "lens-focus" },
> > > + { MIPI_IMG_PREFIX "flash-leds", "flash-leds" },
> > > + { MIPI_IMG_PREFIX "clock-frequency", "clock-frequency" },
> > > + { MIPI_IMG_PREFIX "led-max-current", "led-max-microamp" },
> > > + { MIPI_IMG_PREFIX "flash-max-current", "flash-max-microamp" },
> > > + { MIPI_IMG_PREFIX "flash-max-timeout", "flash-max-timeout-us" },
> >
> > I don't thing it ads to the readability, so I don't know why this (part of the)
> > change is needed.
>
> Ok, I'll drop this chunk.
Thank you. What you can do, though, is to make the second list on the same
column (in the previous patch) if you consider it would be better.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-24 16:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:46 [PATCH v2 0/8] ACPI _CRS CSI-2 and MIPI DisCo for Imaging support Sakari Ailus
2023-01-23 13:46 ` [PATCH v2 1/8] ACPI: property: Parse data node string references in properties Sakari Ailus
2023-01-23 14:51 ` Andy Shevchenko
2023-01-23 15:53 ` Sakari Ailus
2023-01-23 17:19 ` Andy Shevchenko
2023-01-23 13:46 ` [PATCH v2 2/8] ACPI: property: Parse _CRS CSI-2 descriptor Sakari Ailus
2023-01-23 15:07 ` Andy Shevchenko
2023-01-23 16:07 ` Sakari Ailus
2023-01-23 17:25 ` Andy Shevchenko
2023-01-24 15:52 ` Sakari Ailus
2023-01-24 16:40 ` Andy Shevchenko
2023-01-23 13:46 ` [PATCH v2 3/8] device property: Add SOFTWARE_NODE() macro for defining software nodes Sakari Ailus
2023-01-24 11:40 ` Heikki Krogerus
2023-01-23 13:46 ` [PATCH v2 4/8] ACPI: property: Generate camera swnodes for ACPI and DisCo for Imaging Sakari Ailus
2023-01-23 15:23 ` Andy Shevchenko
2023-01-24 15:43 ` Sakari Ailus
2023-01-24 16:38 ` Andy Shevchenko
2023-01-25 8:34 ` Sakari Ailus
2023-01-24 19:26 ` Andy Shevchenko
2023-01-24 19:32 ` Andy Shevchenko
2023-01-25 8:56 ` Sakari Ailus
2023-01-25 11:46 ` Andy Shevchenko
2023-01-25 11:53 ` Sakari Ailus
2023-01-25 12:00 ` Andy Shevchenko
2023-01-25 12:02 ` Andy Shevchenko
2023-01-23 13:46 ` [PATCH v2 5/8] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS Sakari Ailus
2023-01-23 13:46 ` [PATCH v2 6/8] ACPI: property: Rename parsed MIPI DisCo for Imaging properties Sakari Ailus
2023-01-23 13:46 ` [PATCH v2 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix Sakari Ailus
2023-01-23 15:27 ` Andy Shevchenko
2023-01-24 15:54 ` Sakari Ailus
2023-01-24 16:41 ` Andy Shevchenko [this message]
2023-01-25 8:25 ` Sakari Ailus
2023-01-23 13:46 ` [PATCH v2 8/8] ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9AKKlqx7qbkQMuS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox