From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1C9C25B50 for ; Tue, 24 Jan 2023 19:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230404AbjAXT0g (ORCPT ); Tue, 24 Jan 2023 14:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233239AbjAXT0f (ORCPT ); Tue, 24 Jan 2023 14:26:35 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C3E49410; Tue, 24 Jan 2023 11:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674588394; x=1706124394; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=f87d/zZp24KkZDTptfKewrZv/NUpZ83pjn5jl9dytgk=; b=BRXOheT0tNuVXjlGrSFymz9vCSAehuevveGhwlN32174DCLxYGcwTsPU L2sDYP3ZtjJj8fXO8aT56bPhoWbyCVNbKfUlOrkFgTYOrhoVjePdg6azw mDHGeuSSGkoOv/WTeyn0Fuy3A26HnkbqWfiIOy8c2fckl12OY7+bDZ/CM Lm4xiKG4YbYXdwQUzIizH7Jf9KgQsUW5+R9EZLyOuKXXoo00K656+lhjo lRZTY5aWWz86M4b19RHopfGNI7+c6VW2MDVjz6xiba69EKb+H0MJwZYqR zee48ZcksmvtBOcr5VSOl+ukG/PsQNilB0Ws0te18qHUXiIZmRxVlv/we Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="324084949" X-IronPort-AV: E=Sophos;i="5.97,243,1669104000"; d="scan'208";a="324084949" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 11:26:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="730796601" X-IronPort-AV: E=Sophos;i="5.97,243,1669104000"; d="scan'208";a="730796601" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 24 Jan 2023 11:26:32 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pKOwB-00EVWP-1E; Tue, 24 Jan 2023 21:26:31 +0200 Date: Tue, 24 Jan 2023 21:26:31 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org, rafael@kernel.org, heikki.krogerus@linux.intel.com Subject: Re: [PATCH v2 4/8] ACPI: property: Generate camera swnodes for ACPI and DisCo for Imaging Message-ID: References: <20230123134617.265382-1-sakari.ailus@linux.intel.com> <20230123134617.265382-5-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123134617.265382-5-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jan 23, 2023 at 03:46:13PM +0200, Sakari Ailus wrote: As promised the idea of bitmap APIs. Also I have stumbled over couple of suspicious places. See below. ... > +static void init_port_csi2_common(struct acpi_device *device, > + struct fwnode_handle *mipi_port_fwnode, > + unsigned int *ep_prop_index, > + unsigned int port_nr) > +{ > + unsigned int port_index = next_csi2_port_index(device->swnodes, port_nr); > + struct acpi_device_software_nodes *ads = device->swnodes; > + struct acpi_device_software_node_port *port = &ads->ports[port_index]; > + unsigned int num_lanes = 0; > + union { > + u32 val; // Not sure why this even exists. // And hence why do we need union? > + /* Data lanes + the clock lane */ > + u8 val8[BITS_TO_BYTES(ARRAY_SIZE(port->data_lanes) + 1)]; > + } u; Somewhere #define MAX_LANES(port) (ARRAY_SIZE((port)->data_lanes) + 1) u8 val8[BITS_TO_BYTES(MAX_LANES(port))]; ... /* Data lanes + the clock lane */ DECLARE_BITMAP(polarity, MAX_LANES(port))); > + int ret; > + > + *ep_prop_index = ACPI_DEVICE_SWNODE_EP_CLOCK_LANES; > + > + if (GRAPH_PORT_NAME(port->port_name, port_nr)) > + return; > + > + ads->nodes[ACPI_DEVICE_SWNODE_PRT(port_index)] = > + SOFTWARE_NODE(port->port_name, port->port_props, > + &ads->nodes[ACPI_DEVICE_SWNODE_ROOT]); > + > + ret = fwnode_property_read_u8(mipi_port_fwnode, "mipi-img-clock-lane", u.val8); > + if (!ret) { > + port->ep_props[NEXT_PROPERTY(*ep_prop_index, EP_CLOCK_LANES)] = > + PROPERTY_ENTRY_U32("clock-lanes", *u.val8); > + } > + ret = fwnode_property_count_u8(mipi_port_fwnode, "mipi-img-data-lanes"); > + if (ret > 0) { > + num_lanes = ret; > + > + if (num_lanes > ARRAY_SIZE(port->data_lanes)) { >= MAX_LANES(port) > + acpi_handle_warn(acpi_device_handle(device), > + "too many data lanes (%u)\n", > + num_lanes); > + num_lanes = ARRAY_SIZE(port->data_lanes); = MAX_LANES(port) - 1; > + } > + > + ret = fwnode_property_read_u8_array(mipi_port_fwnode, "mipi-img-data-lanes", > + u.val8, num_lanes); > + if (!ret) { > + unsigned int i; > + > + for (i = 0; i < num_lanes; i++) > + port->data_lanes[i] = u.val8[i]; > + > + port->ep_props[NEXT_PROPERTY(*ep_prop_index, EP_DATA_LANES)] = > + PROPERTY_ENTRY_U32_ARRAY_LEN("data-lanes", port->data_lanes, > + num_lanes); > + } > + } > + ret = fwnode_property_read_u8_array(mipi_port_fwnode, > + "mipi-img-lane-polarities", > + u.val8, sizeof(u.val8)); > + if (ret > 0) { How is it supposed to work?! > + unsigned int bytes = ret; > + > + /* Total number of lanes here is clock lane + data lanes */ > + if (bytes * BITS_PER_TYPE(u8) >= 1 + num_lanes) { > + unsigned int i; > + > + /* Move polarity bits to the lane polarity u32 array */ > + for (i = 0; i < 1 + num_lanes; i++) > + port->lane_polarities[i] = > + (u.val8[i >> 3] & (1 << (i & 7))) ? > + 1U : 0U; > + > + port->ep_props[NEXT_PROPERTY(*ep_prop_index, EP_LANE_POLARITIES)] = > + PROPERTY_ENTRY_U32_ARRAY_LEN("lane-polarities", > + port->lane_polarities, > + 1 + num_lanes); > + } else { > + acpi_handle_warn(acpi_device_handle(device), > + "too few lane polarity bytes (%u)\n", > + bytes); > + } > + } ret = fwnode_property_count_u8(mipi_port_fwnode, "mipi-img-dlane-polarities"); if (ret < 0) { acpi_handle_debug(acpi_device_handle(device), "no lane polarity provided\n"); } else if (ret < 1 + num_lanes) { acpi_handle_warn(acpi_device_handle(device), "too few lane polarity bytes (%u)\n", bytes); } else { // assuming we dropped the union and renamed to val... ret = fwnode_property_read_u8_array(mipi_port_fwnode, "mipi-img-lane-polarities", val, sizeof(val)); if (ret) { ...can't read... (debug message?) } else { unsigned int i; for (i = 0; i < 1 + num_lanes; i++) bitmap_set_value8(polarity, val[i], i * BITS_PER_BYTE); // assuming that lane_polarities is zeroed by default... for_each_set_bit(i, polarity, 1 + num_lanes) port->lane_polarities[i] = 1; } } > + ads->nodes[ACPI_DEVICE_SWNODE_EP(port_index)] = > + SOFTWARE_NODE("endpoint@0", ads->ports[port_index].ep_props, > + &ads->nodes[ACPI_DEVICE_SWNODE_PRT(port_index)]); > +} -- With Best Regards, Andy Shevchenko