Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink

Andy Shevchenko
2023-01-27T09:45:06Z

On Fri, Jan 27, 2023 at 10:30:35AM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 27, 2023 at 10:25 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote:

...

> > > - of_node_set_flag(np, OF_POPULATED);
> > > + fwnode_dev_initialized(&np->fwnode, true);
> >
> > of_fwnode_handle(np) ?
>
> Or of_node_to_fwnode().

Not really.

> Looks like we have (at least) two of them...

Yes, and the latter one is IRQ subsystem invention. Should gone in favour of
the generic helper.

--
With Best Regards,
Andy Shevchenko