Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links

Andy Shevchenko
2023-01-27T09:31:09Z

On Fri, Jan 27, 2023 at 11:29:43AM +0200, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote:

...

> > DL_FLAG_AUTOREMOVE_SUPPLIER | \
> > DL_FLAG_AUTOPROBE_CONSUMER | \
> > DL_FLAG_SYNC_STATE_ONLY | \
> > - DL_FLAG_INFERRED)
> > + DL_FLAG_INFERRED | \
> > + DL_FLAG_CYCLE)
>
> You can make less churn by squeezing the new one above the last one.

Or even define a mask with all necessary bits in the header and use it.

--
With Best Regards,
Andy Shevchenko