Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links

Andy Shevchenko
2023-01-30T12:10:59Z

On Fri, Jan 27, 2023 at 11:34:11PM -0800, Saravana Kannan wrote:
> On Fri, Jan 27, 2023 at 1:30 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote:

...

> > > DL_FLAG_AUTOREMOVE_SUPPLIER | \
> > > DL_FLAG_AUTOPROBE_CONSUMER | \
> > > DL_FLAG_SYNC_STATE_ONLY | \
> > > - DL_FLAG_INFERRED)
> > > + DL_FLAG_INFERRED | \
> > > + DL_FLAG_CYCLE)
> >
> > You can make less churn by squeezing the new one above the last one.
>
> I feel like this part is getting bike shedded. I'm going to leave it
> as is. It's done in the order it's defined in the header and keeping
> it that way makes it way more easier to read than worry about a single
> line churn.

Not at all. What you are showing here is the additional churn for the sake of
the churn. With a no-cost trick you may avoid that.

Also, it will compress better the Git index and save some mW here and there
and in the size of the world and amount of Git copies of the Linux kernel
this may save the planet (I'm serious, no jokes).

--
With Best Regards,
Andy Shevchenko