Re: [PATCH v2 05/11] driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links

Geert Uytterhoeven
2023-01-27T09:56:23Z

On Fri, Jan 27, 2023 at 10:30 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Jan 26, 2023 at 04:11:32PM -0800, Saravana Kannan wrote:

> > DL_FLAG_AUTOREMOVE_SUPPLIER | \
> > DL_FLAG_AUTOPROBE_CONSUMER | \
> > DL_FLAG_SYNC_STATE_ONLY | \
> > - DL_FLAG_INFERRED)
> > + DL_FLAG_INFERRED | \
> > + DL_FLAG_CYCLE)
>
> You can make less churn by squeezing the new one above the last one.

And avoiding some future churn by introducing alphabetical order.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds