From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1978FC433E0 for ; Mon, 1 Feb 2021 15:21:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2C1C64DBD for ; Mon, 1 Feb 2021 15:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbhBAPVD (ORCPT ); Mon, 1 Feb 2021 10:21:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbhBAPUw (ORCPT ); Mon, 1 Feb 2021 10:20:52 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F51C06174A for ; Mon, 1 Feb 2021 07:20:12 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id 6so16983361wri.3 for ; Mon, 01 Feb 2021 07:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Cmku5S3IdYnPtrqwdeFlSVFh/nDWdiVLKGao8LWxXgA=; b=JqbVGM0UCNG3mit9/UZsdLhah1nWurom48htD5nfPqgCrIDKO88AnVFFjgeU8PHGAN BW8utbpUX3UzYrG5TduBBHDR0Bykf1U/mPNECk9CAeP2BJ5xU1/maQPp6TdmWvSxp7kY YaRWr2KxZf1lmghsWGCPIcwDMqfE9K6FbmmNMq6gHY0Jz8AKQFReCAkxEqamQ7k25E05 tww76nG6EjFgx1g6ImqskqU/4QT+Wut06Spo5/okwB798IwVUNUls7lmhj5a+eDAZLFh piOGzeHarIzIg/xyItedJcc03d6rBcyoHWFaeuijtP9yye49mw6dbw4S7T1r8qkcImZk PFDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cmku5S3IdYnPtrqwdeFlSVFh/nDWdiVLKGao8LWxXgA=; b=lXHnKZc6n2tWBwtLKHbDXecvVwiO00w1uahWnL0qU/6OMsiI7mBHDbhYfxNOziSoIX Kq4jYGYX1fV69N8Uu3U7CfSWHY73PGSooj4P9bQ3mIe26ndyXdt49lGKkXSYZi03DEhZ x6SFZ417R6qpATHHxffh8Dit5DWtLU6NrOzSDEfJmUgreGkwNgYjvIGfWROW8jZHX3HS lmbAbU+ML5RZdC+8RNxVDKgliIBimX/aFkxjvEPW0vHWg7cidYMlYrYMSxO7QvyWIy1q jsJNqsBMfl9baZT7OXRxzbuZFRHuiMA2GIrVN/xICME9wviNgTKT5arpbUEXgML8oVZ1 fXHQ== X-Gm-Message-State: AOAM533kP/ZR40I45bwF71KkGcISt6rIPPqfMqF/yYtvGXQpyY4NdjWN 2LdficFaMYwVsUgQwMaOEZqes2QCf7zjUw== X-Google-Smtp-Source: ABdhPJxNabzA7H0H3DOfoTeFLSfKWAgMXTatTFFBoCico1yZQV+n2lKonsKcsD7PxZ66kwPkc5AE0w== X-Received: by 2002:a5d:4528:: with SMTP id j8mr19018125wra.352.1612192810877; Mon, 01 Feb 2021 07:20:10 -0800 (PST) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id q6sm25951090wrw.43.2021.02.01.07.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 07:20:09 -0800 (PST) Date: Mon, 1 Feb 2021 16:19:50 +0100 From: Jean-Philippe Brucker To: Auger Eric Cc: vivek.gautam@arm.com, guohanjun@huawei.com, will@kernel.org, lorenzo.pieralisi@arm.com, joro@8bytes.org, linux-acpi@vger.kernel.org, zhangfei.gao@linaro.org, lenb@kernel.org, devicetree@vger.kernel.org, kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net, shameerali.kolothum.thodi@huawei.com, iommu@lists.linux-foundation.org, sudeep.holla@arm.com, robin.murphy@arm.com, linux-accelerators@lists.ozlabs.org, baolu.lu@linux.intel.com Subject: Re: [PATCH v12 10/10] iommu/arm-smmu-v3: Add stall support for platform devices Message-ID: References: <20210127154322.3959196-1-jean-philippe@linaro.org> <20210127154322.3959196-11-jean-philippe@linaro.org> <0c609eeb-00b0-7573-fed7-5bc1e6c0b0d1@redhat.com> <47a65f65-26cb-de27-049a-48f2d083964a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47a65f65-26cb-de27-049a-48f2d083964a@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 01, 2021 at 02:16:16PM +0100, Auger Eric wrote: > >>> + flt->type = IOMMU_FAULT_DMA_UNRECOV; > >>> + flt->event = (struct iommu_fault_unrecoverable) { > >>> + .reason = reason, > >>> + .flags = IOMMU_FAULT_UNRECOV_ADDR_VALID | > >>> + IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID, > >> nit: shall IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID be set here? Supported > >> unrecoverable faults feature the IPA field which is UNKNOWN for S1 > >> translations. fetch_addr rather was > >> corresponding to WALK_EABT.Fetch_addr to me. > > > > Right I should drop the IPA part entirely, since we don't report S2 faults > > in this patch. > OK > > But as I mentioned this can be fixed separately if you don't have other > comments on this version. Thanks, I need to resend anyway to fix patch 7. Thanks, Jean