From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D902DC433DB for ; Thu, 11 Feb 2021 15:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A68C64E8B for ; Thu, 11 Feb 2021 15:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbhBKPpv (ORCPT ); Thu, 11 Feb 2021 10:45:51 -0500 Received: from mga03.intel.com ([134.134.136.65]:52779 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbhBKPoM (ORCPT ); Thu, 11 Feb 2021 10:44:12 -0500 IronPort-SDR: JpQupExjmq6mtb9pF/I915wBApfbGedsPOlt6XjSmXyo8Xm8HSeUpiQ6eeM4P4ZCl5dmEJWEpy D+gzr/MSvDAA== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="182332443" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="182332443" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 07:42:22 -0800 IronPort-SDR: 1bj7VsNtsDJU38kaYGWQgyRAa6CpRn5nQBB9VLr6ny7kZ2w25e3QviKjulCGQKZj12/UeaVrrb jnrYHSKXgIYw== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="437156945" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 07:42:20 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lAE6k-004Fw6-16; Thu, 11 Feb 2021 17:42:18 +0200 Date: Thu, 11 Feb 2021 17:42:18 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , ACPI Devel Maling List , Linux Kernel Mailing List , Len Brown , Calvin Johnson Subject: Re: [PATCH v1 7/7] ACPI: property: Allow counting a single value as an array of 1 element Message-ID: References: <20210210114320.3478-1-andriy.shevchenko@linux.intel.com> <3881654.NPl3a4M0kB@kreacher> <1946478.1QpZic6vku@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Feb 10, 2021 at 04:44:34PM +0100, Rafael J. Wysocki wrote: > On Wed, Feb 10, 2021 at 4:42 PM Andy Shevchenko > wrote: > > On Wed, Feb 10, 2021 at 04:01:16PM +0100, Rafael J. Wysocki wrote: > > > On Wed, Feb 10, 2021 at 3:48 PM Andy Shevchenko > > > wrote: > > > > On Wed, Feb 10, 2021 at 02:48:09PM +0100, Rafael J. Wysocki wrote: > > > > > On Wednesday, February 10, 2021 2:31:48 PM CET Rafael J. Wysocki wrote: > > > > > > On Wednesday, February 10, 2021 1:36:00 PM CET Rafael J. Wysocki wrote: > > > > > > > On Wed, Feb 10, 2021 at 12:51 PM Andy Shevchenko > > > > > > > wrote: ... > > > > > > > > - if (val && nval == 1) { > > > > > > > > + /* Try to read as a single value first */ > > > > > > > > + if (!val || nval == 1) { > > > > > > > > ret = acpi_data_prop_read_single(data, propname, proptype, val); > > > > > > > > > > > > > > This returns -EINVAL if val is NULL. > > > > > > > > Nope. That's why it's a patch 7. Patch 6 solves this. > > > > > > That's my point. Patch 7 should be the first one in the series. > > > > Ah, okay. Since you want this let me rebase. > > Thanks! I started rebasing and realised that your approach has swapped the error codes, i.e. if it's a single-value and it is, e.g., 16-bit wide, the u8 read will return 1, while it has to return -EOVERFLOW. If you prefer, I can move two patches to the beginning, so one will be a good prerequisite for this fix. And I'm still unsure about stable (Fixes tag is okay to me), because the counting never worked from the day 1. -- With Best Regards, Andy Shevchenko