From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT
Date: Tue, 23 Feb 2021 13:51:53 +0200 [thread overview]
Message-ID: <YDTsWR/kXhd96ICI@smile.fi.intel.com> (raw)
In-Reply-To: <1614069358-50943-1-git-send-email-yang.lee@linux.alibaba.com>
On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index e37a57d..86efa2d 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,
> int ret, value;
>
> ret = request_threaded_irq(event->irq, NULL, event->handler,
> - event->irqflags, "ACPI:Event", event);
> + event->irqflags | IRQF_ONESHOT, "ACPI:Event", event);
> if (ret) {
> dev_err(acpi_gpio->chip->parent,
> "Failed to setup interrupt handler for %d\n",
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-23 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 8:35 [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT Yang Li
2021-02-23 11:51 ` Andy Shevchenko [this message]
2021-02-25 15:06 ` Andy Shevchenko
2021-03-01 13:57 ` Bartosz Golaszewski
2021-03-01 14:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDTsWR/kXhd96ICI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox