From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F634C433E0 for ; Thu, 25 Feb 2021 15:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BEE464F20 for ; Thu, 25 Feb 2021 15:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232588AbhBYPIr (ORCPT ); Thu, 25 Feb 2021 10:08:47 -0500 Received: from mga09.intel.com ([134.134.136.24]:30880 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbhBYPIe (ORCPT ); Thu, 25 Feb 2021 10:08:34 -0500 IronPort-SDR: hsQFVcoLI27OjOjt8uaYYa/llSKirjCGWhv+I9x5T4dhj5Pz2589dSHu9LWnE2Tp5fwMMd2yV+ XB1qexRQJfFA== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="185679076" X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="185679076" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 07:06:43 -0800 IronPort-SDR: SOv2HaqhEGEtFQUkLc6tuMoLrqzmYVpZ3NtE8G1HueEITGgabUIAGpVCSZK2KzWrblm5ROpM6F mI30XGEDO10A== X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="442611084" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 07:06:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lFIDv-0082r4-8f; Thu, 25 Feb 2021 17:06:39 +0200 Date: Thu, 25 Feb 2021 17:06:39 +0200 From: Andy Shevchenko To: Yang Li Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT Message-ID: References: <1614069358-50943-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > fixed the following coccicheck: > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > primary handler requested without IRQF_ONESHOT > > > > Make sure threaded IRQs without a primary handler are always request > > with IRQF_ONESHOT > > Acked-by: Andy Shevchenko Bart, I guess I will collect this in my branch and send you a PR. I have more fixes to that file anyway. -- With Best Regards, Andy Shevchenko