From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0EEC433DB for ; Mon, 1 Mar 2021 14:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 580A864DF5 for ; Mon, 1 Mar 2021 14:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236403AbhCAOc2 (ORCPT ); Mon, 1 Mar 2021 09:32:28 -0500 Received: from mga01.intel.com ([192.55.52.88]:40501 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236379AbhCAOcQ (ORCPT ); Mon, 1 Mar 2021 09:32:16 -0500 IronPort-SDR: QvXHoElGDeee9yA2PaPU8Wi1ahrcSgw/QZ+KT9i63TYLmLJCYJ27Qt1PEcWTSK6k6YeXequ6Ia gVzS8b08Vtsg== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="206090285" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="206090285" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 06:30:26 -0800 IronPort-SDR: NwcDCNj7XqUq2dqA/wMXN8k6qUH7EnB3cPbBpvBsONTNpZiWHAfkW71mvbZ4evOnT2LbMhsizH oLnGqg0Ar3GA== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="383074888" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 06:30:23 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lGjYx-0099w2-Dv; Mon, 01 Mar 2021 16:30:19 +0200 Date: Mon, 1 Mar 2021 16:30:19 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Yang Li , Mika Westerberg , Linus Walleij , linux-gpio , ACPI Devel Maling List , LKML Subject: Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT Message-ID: References: <1614069358-50943-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 01, 2021 at 02:57:53PM +0100, Bartosz Golaszewski wrote: > On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko > wrote: > > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > > > fixed the following coccicheck: > > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > > > primary handler requested without IRQF_ONESHOT > > > > > > > > Make sure threaded IRQs without a primary handler are always request > > > > with IRQF_ONESHOT > > > > > > Acked-by: Andy Shevchenko > > > > Bart, I guess I will collect this in my branch and send you a PR. > > I have more fixes to that file anyway. > > Fine with me! Good! So, when you have time, please review [1] and I'll send PR for fixes. [1]: https://lore.kernel.org/linux-gpio/20210225163320.71267-1-andriy.shevchenko@linux.intel.com/T/#u -- With Best Regards, Andy Shevchenko