From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Yong Zhi <yong.zhi@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 3/8] software node: Show properties and their values in sysfs
Date: Sun, 28 Mar 2021 15:02:24 +0200 [thread overview]
Message-ID: <YGB+YMh1MsQao3zS@kroah.com> (raw)
In-Reply-To: <CAHp75VfFzqpdR+6p9vQww-ujQcw3L-V_N7ezUTGhcRmvwvqMZg@mail.gmail.com>
On Sun, Mar 28, 2021 at 03:56:26PM +0300, Andy Shevchenko wrote:
> On Sun, Mar 28, 2021 at 9:47 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, Mar 28, 2021 at 12:20:07AM +0200, Andy Shevchenko wrote:
> > > It's very convenient to see what properties and their values
> > > are currently being assigned in the registered software nodes.
> > >
> > > Show properties and their values in sysfs.
>
> ...
>
> > > + for (i = 0; i < prop->length / sizeof(u8); i++)
> > > + len += sysfs_emit_at(buf, len, "%u,", ((u8 *)pointer)[i]);
> >
> > No, sysfs is "one value per file", and that is not what you are showing
> > here at all :(
>
> It is following: it's a "one value" for property in question,
>
> As we may read in [1]: "...so it is socially acceptable to express an
> array of values of the same type."
>
> And here is exactly the case: *values of the same type*.
So what is it going to look like exactly? And what tool is going to be
there to parse this mess? Who is going to to use it?
Arrays of data are not "one value".
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-28 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 22:20 [PATCH v1 1/8] software node: Free resources explicitly when swnode_register() fails Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 2/8] software node: Introduce software_node_alloc()/software_node_free() Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 3/8] software node: Show properties and their values in sysfs Andy Shevchenko
2021-03-28 1:14 ` kernel test robot
2021-03-28 6:45 ` Greg Kroah-Hartman
2021-03-28 12:56 ` Andy Shevchenko
2021-03-28 13:02 ` Greg Kroah-Hartman [this message]
2021-03-29 13:01 ` Andy Shevchenko
2021-03-29 13:46 ` Greg Kroah-Hartman
2021-03-29 14:51 ` Andy Shevchenko
2021-03-29 18:26 ` Greg Kroah-Hartman
2021-03-27 22:20 ` [PATCH v1 4/8] software node: Deduplicate code in fwnode_create_software_node() Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 5/8] software node: Imply kobj_to_swnode() to be no-op Andy Shevchenko
2021-03-28 8:43 ` Greg Kroah-Hartman
2021-03-28 12:50 ` Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 6/8] software node: Simplify swnode_register() a bit Andy Shevchenko
2021-03-28 8:44 ` Greg Kroah-Hartman
2021-03-28 12:50 ` Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 7/8] software node: Introduce SOFTWARE_NODE_REFERENCE() helper macro Andy Shevchenko
2021-03-27 22:20 ` [PATCH v1 8/8] media: ipu3-cio2: Switch to use SOFTWARE_NODE_REFERENCE() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGB+YMh1MsQao3zS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox