From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B513C433DB for ; Sun, 28 Mar 2021 08:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1065461971 for ; Sun, 28 Mar 2021 08:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbhC1In3 (ORCPT ); Sun, 28 Mar 2021 04:43:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:36894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhC1InE (ORCPT ); Sun, 28 Mar 2021 04:43:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EAECC61966; Sun, 28 Mar 2021 08:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616920983; bh=C12zvsMmJIgwjjVR8lLlhOry1XH7ndkALgxogosrSII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aQhfvQuGN0orJE2YPxaMD3P141ZcKFgBS32IkIPZsIbWQi8eUrVED8bPB4ye4jDRJ wYoz2Rsqkbz3HgKXjbRZ+2FHfNYGjwN+OqCO/js5DN5mogusiK+T0LtJwmgyP8UTa4 mOTVDiCH7JqlrL9sjT0NpCGrj8M/K3MqL/qFGmQc= Date: Sun, 28 Mar 2021 10:43:00 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Heikki Krogerus Subject: Re: [PATCH v1 5/8] software node: Imply kobj_to_swnode() to be no-op Message-ID: References: <20210327222012.54103-1-andriy.shevchenko@linux.intel.com> <20210327222012.54103-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327222012.54103-5-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sun, Mar 28, 2021 at 12:20:09AM +0200, Andy Shevchenko wrote: > Since we don't use structure field layout randomization > the manual shuffling can affect some macros, in particular > kobj_to_swnode(), which becomes a no-op when kobj member > is the first one in the struct swnode. > > Bloat-o-meter statistics: > > add/remove: 0/0 grow/shrink: 2/10 up/down: 9/-100 (-91) > Total: Before=7217, After=7126, chg -1.26% > > Signed-off-by: Andy Shevchenko > --- > drivers/base/swnode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 22f81688af2c..ae53c48f84b1 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -13,10 +13,10 @@ > #include > > struct swnode { > - int id; > struct kobject kobj; > struct fwnode_handle fwnode; > const struct software_node *node; > + int id; So you remove one math operation on a pointer and get a 1% size decrease of the whole kernel? Or just one file? thanks, greg k-h