From: Joerg Roedel <jroedel@suse.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI/APCI: Move acpi_pci_osc_support() check to negotiation phase
Date: Mon, 7 Jun 2021 16:14:03 +0200 [thread overview]
Message-ID: <YL4pq0oJyZfSWeTV@suse.de> (raw)
In-Reply-To: <CAJZ5v0iDxpYxz3_8RrWSJkM7cf=xS298agXcULm3EqRC++GD2g@mail.gmail.com>
On Mon, Jun 07, 2021 at 02:56:24PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jun 4, 2021 at 7:09 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > If either "pcie_ports_disabled" or Linux doesn't support everything in
> > ACPI_PCIE_REQ_SUPPORT, we will never evaluate _OSC at all, so
> > the platform won't know that Linux has OSC_PCI_SEGMENT_GROUPS_SUPPORT,
> > OSC_PCI_HPX_TYPE_3_SUPPORT, OSC_PCI_EXT_CONFIG_SUPPORT, etc.
>
> Right.
Thanks Bjorn and Rafael. So I think the important thing to do is to
issue at least one _OSC call even when Linux is not trying to take
control of anything.
I look into a clean way to do this and get the kernel messages right.
One thing to change is probably only calculating 'control' if
!pcie_ports_disabled in negotiate_os_control().
Regards,
Joerg
next prev parent reply other threads:[~2021-06-07 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 12:48 [PATCH] PCI/APCI: Move acpi_pci_osc_support() check to negotiation phase Joerg Roedel
2021-06-03 20:50 ` Bjorn Helgaas
2021-06-04 17:09 ` Bjorn Helgaas
2021-06-07 12:56 ` Rafael J. Wysocki
2021-06-07 14:14 ` Joerg Roedel [this message]
2021-06-07 14:18 ` Rafael J. Wysocki
2021-06-07 14:10 ` Joerg Roedel
2021-06-07 15:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL4pq0oJyZfSWeTV@suse.de \
--to=jroedel@suse.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=joro@8bytes.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox