From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
platform-driver-x86@vger.kernel.org, devel@acpica.org,
Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Wolfram Sang <wsa@kernel.org>,
Mark Gross <mgross@linux.intel.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
laurent.pinchart@ideasonboard.com,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v5 4/6] gpiolib: acpi: Add acpi_gpio_get_io_resource()
Date: Fri, 4 Jun 2021 17:33:36 +0300 [thread overview]
Message-ID: <YLo5wFds5JdE82P/@smile.fi.intel.com> (raw)
In-Reply-To: <ca51ab71-9cdd-0d00-959f-9e1b2df3588c@gmail.com>
On Fri, Jun 04, 2021 at 03:09:43PM +0100, Daniel Scally wrote:
> On 04/06/2021 14:01, Andy Shevchenko wrote:
> > On Thu, Jun 03, 2021 at 11:40:05PM +0100, Daniel Scally wrote:
> >> Add a function to verify that a given acpi_resource represents an IO
> >> type GPIO resource, and return it if so.
> > I would rephrase this to something like:
> >
> > "Add a function to verify that a given ACPI resource represents a GpioIo() type
> > of resource, and return it if so."
> >
> > I can amend when applying to my branch.
> >
> That wording is perfectly fine by me
These two patches (with mentioned amendments) pushed to my review and testing
queue, thanks!
I'll send PR next week to all stakeholders.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-04 14:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 22:40 [PATCH v5 0/6] Introduce intel_skl_int3472 module Daniel Scally
2021-06-03 22:40 ` [PATCH v5 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally
2021-06-03 22:40 ` [PATCH v5 2/6] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally
2021-06-07 14:52 ` Rafael J. Wysocki
2021-06-03 22:40 ` [PATCH v5 3/6] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally
2021-06-04 12:59 ` Andy Shevchenko
2021-06-04 14:09 ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 4/6] gpiolib: acpi: Add acpi_gpio_get_io_resource() Daniel Scally
2021-06-04 13:01 ` Andy Shevchenko
2021-06-04 14:09 ` Daniel Scally
2021-06-04 14:33 ` Andy Shevchenko [this message]
2021-06-04 16:54 ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 5/6] platform/x86: Add intel_skl_int3472 driver Daniel Scally
2021-06-04 1:31 ` kernel test robot
2021-06-05 23:07 ` Daniel Scally
2021-06-04 6:49 ` kernel test robot
2021-06-16 17:58 ` Hans de Goede
2021-06-16 18:08 ` Andy Shevchenko
2021-06-16 18:13 ` Hans de Goede
2021-06-16 21:42 ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 6/6] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally
2021-06-17 11:14 ` Hans de Goede
2021-06-08 9:00 ` [PATCH v5 0/6] Introduce intel_skl_int3472 module Hans de Goede
2021-06-08 9:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLo5wFds5JdE82P/@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@acpica.org \
--cc=djrscally@gmail.com \
--cc=erik.kaneda@intel.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox