From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linux GPIO <linux-gpio@vger.kernel.org>,
linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: David Thompson <davthompson@nvidia.com>,
Asmaa Mnebhi <asmaa@nvidia.com>, Liming Sun <limings@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: Possible ACPI abuse in Mellanox BlueField Gigabit Ethernet driver
Date: Thu, 12 Aug 2021 17:15:34 +0300 [thread overview]
Message-ID: <YRUtBr2rVNNfFdGF@smile.fi.intel.com> (raw)
In-Reply-To: <YRUskkALrPLa2cSf@smile.fi.intel.com>
+Cc: Hans (on FYI basis)
On Thu, Aug 12, 2021 at 05:13:38PM +0300, Andy Shevchenko wrote:
> Hi!
>
> From time to time I do grep kernel for ACPI_RESOURCE_TYPE_GPIO usage.
> Recently the drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
> caught my eye.
>
> Looking into the code I see that it looks like misunderstanding of how ACPI
> works with GPIOs. First of all, I would like to inform that this code has
> been properly reviewed neither by GPIO nor by ACPI maintainers. Second, before
> going it to the real conclusions (and potential revert of this), I would like
> to see the real ACPI tables for this and some explanations from the authors of
> the driver about GPIO usage here (from hw and sw perspectives).
>
> It makes sense to discuss ASAP, otherwise I would really want to revert it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-12 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 14:13 Possible ACPI abuse in Mellanox BlueField Gigabit Ethernet driver Andy Shevchenko
2021-08-12 14:15 ` Andy Shevchenko [this message]
2021-08-12 15:54 ` Asmaa Mnebhi
2021-08-12 16:25 ` Andy Shevchenko
2021-08-12 20:07 ` Asmaa Mnebhi
2021-08-13 13:50 ` Andy Shevchenko
2021-08-13 14:32 ` Asmaa Mnebhi
2021-08-16 12:11 ` Andy Shevchenko
2021-08-12 21:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRUtBr2rVNNfFdGF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=asmaa@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=limings@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox