Re: [PATCH v1 1/1] x86/platform: Increase maximum GPIO number for X86_64

Andy Shevchenko
2021-08-16T14:48:52Z

On Mon, Aug 16, 2021 at 03:55:59PM +0200, Rafael J. Wysocki wrote:
> On Mon, Aug 16, 2021 at 3:35 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Aug 16, 2021 at 03:25:13PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Aug 6, 2021 at 4:44 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:

...

> > > Wouldn't
> > >
> > > default 1024 if X86_64
> > > default 512
> > >
> > > be sufficient?
> > >
> > > It's either X86_64 or X86_32 anyway AFAICS.

Fixed in v2.

...

> > Btw, what do you think. do we need comment above and help text here? I copied
> > these from ARM, but I'm not sure it would be useful on x86 as much.
>
> Both the comment and the help text aren't particularly useful IMO.
>
> The comment is a bit confusing even, because x86 kernels are
> multiplatform as a rule.

Ditto.

--
With Best Regards,
Andy Shevchenko