Re: TPS68470 PMIC config option

Sakari Ailus
2021-09-01T19:32:56Z

Hi Andy, Jean,

On Wed, Sep 01, 2021 at 08:39:19PM +0300, Andy Shevchenko wrote:
> +Cc: Sakari.
>
> On Wed, Sep 01, 2021 at 04:02:34PM +0200, Jean Delvare wrote:
> > Hi Andy,
> >
> > Is there a reason why config TPS68470_PMIC_OPREGION is not under "if
> > PMIC_OPREGION" where all other *_PMIC_OPREGION driver options are?
>
> It was originally like that.
>
> Sakari, do you know?

The answer can be found in Makefile:

obj-$(CONFIG_PMIC_OPREGION) += intel_pmic.o

intel_pmic.c seems to contain common functionality for PMICs in Intel SoCs
whereas the TPS68470 is an external chip. The two codebases are distinct.

Perhaps it could make sense to either rename this as
CONFIG_PMIC_INTEL_OPREGION, or move the TPS68470 driver in and change the
Kconfig+Makefile to have the common code compiled if at least one of the
drivers is enabled.

--
Regards,

Sakari Ailus