From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2A0C433EF for ; Fri, 24 Sep 2021 16:11:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A49956124B for ; Fri, 24 Sep 2021 16:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233752AbhIXQMu (ORCPT ); Fri, 24 Sep 2021 12:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233336AbhIXQMu (ORCPT ); Fri, 24 Sep 2021 12:12:50 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24614C061571; Fri, 24 Sep 2021 09:11:17 -0700 (PDT) Received: from zn.tnic (p200300ec2f0dd600a481e37252848e31.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:d600:a481:e372:5284:8e31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2C5CF1EC03FE; Fri, 24 Sep 2021 18:11:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1632499871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TbX70JSG2rBq6ASh9WJOnkzpbMi1cTCSReNzsMFrWQQ=; b=LDQWBnosGGJ3Q3O/ksdTEIlmwGoeZ/ayCIfBRM5HYaasU18MswfnjjRadCnCOx9VqAoTP3 n2QInL5b0IMkF033onkYYHzj8qisE4g4pWJINtyz8eaMVSj3XHyPbOq4XtB5iEFolSkfXn moUqz1rFpN5lnPH632jUC9hPmRf/eVk= Date: Fri, 24 Sep 2021 18:11:05 +0200 From: Borislav Petkov To: Vasyl Gomonovych Cc: "rafael@kernel.org" , "lenb@kernel.org" , "james.morse@arm.com" , Tony Luck , Randy Dunlap , Yazen Ghannam , Robert Richter , Tom Saeger , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPI: APEI: Check NULL argument in exported symbol Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Sep 24, 2021 at 03:25:03PM +0000, Vasyl Gomonovych wrote: > I found apei_hest_parse() useful API to access the HEST table. # hexdump -C /sys/firmware/acpi/tables/HEST doesn't work for you? Or you want to access it with an out-of-tree driver? > I think RAS development should increase the number of users of > apei_hest_parse(). With this API we can read HEST and modify it. Read > example is to get a count of errors sources from HEST tables from the > external driver and use that counter for driver data allocation. Aha, so with external drivers my suggestion would be is to get it upstream. The upstream kernel doesn't care about out-of-tree users so I'd strongly suggest you try to get that functionality upstream because otherwise that unused export will get removed. HTH. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette