Re: [PATCH v1 3/7] i2c: i2c-amd-mp2-plat: ACPI: Use ACPI_COMPANION() directly

Shyam Sundar S K
2021-10-12T18:13:01Z

On 10/12/2021 11:14 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael@kernel.org>
>
> The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
> macro and the ACPI handle produced by the former comes from the
> ACPI device object produced by the latter, so it is way more
> straightforward to evaluate the latter directly instead of passing
> the handle produced by the former to acpi_bus_get_device().
>
> Modify i2c_amd_probe() accordingly (no intentional functional impact).
>
> Signed-off-by: Rafael J. Wysocki <rafael@kernel.org>

Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

> ---
> drivers/i2c/busses/i2c-amd-mp2-plat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> Index: linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
> ===================================================================
> --- linux-pm.orig/drivers/i2c/busses/i2c-amd-mp2-plat.c
> +++ linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
> @@ -246,12 +246,11 @@ static int i2c_amd_probe(struct platform
> {
> int ret;
> struct amd_i2c_dev *i2c_dev;
> - acpi_handle handle = ACPI_HANDLE(&pdev->dev);
> - struct acpi_device *adev;
> + struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
> struct amd_mp2_dev *mp2_dev;
> const char *uid;
>
> - if (acpi_bus_get_device(handle, &adev))
> + if (!adev)
> return -ENODEV;
>
> /* The ACPI namespace doesn't contain information about which MP2 PCI
>
>
>