Re: [PATCH v1 4/7] surface: surface3-wmi: Use ACPI_COMPANION() directly

Maximilian Luz
2021-10-12T18:13:11Z

On 10/12/21 19:44, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael@kernel.org>
>
> The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
> macro and the ACPI handle produced by the former comes from the
> ACPI device object produced by the latter, so it is way more
> straightforward to evaluate the latter directly instead of passing
> the handle produced by the former to acpi_bus_get_device().
>
> Modify s3_wmi_check_platform_device() accordingly (no intentional
> functional impact).
>
> Signed-off-by: Rafael J. Wysocki <rafael@kernel.org>

Looks good to me.

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

> ---
> drivers/platform/surface/surface3-wmi.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> Index: linux-pm/drivers/platform/surface/surface3-wmi.c
> ===================================================================
> --- linux-pm.orig/drivers/platform/surface/surface3-wmi.c
> +++ linux-pm/drivers/platform/surface/surface3-wmi.c
> @@ -139,13 +139,12 @@ static acpi_status s3_wmi_attach_spi_dev
>
> static int s3_wmi_check_platform_device(struct device *dev, void *data)
> {
> - struct acpi_device *adev, *ts_adev = NULL;
> - acpi_handle handle;
> + struct acpi_device *adev = ACPI_COMPANION(dev);
> + struct acpi_device *ts_adev = NULL;
> acpi_status status;
>
> /* ignore non ACPI devices */
> - handle = ACPI_HANDLE(dev);
> - if (!handle || acpi_bus_get_device(handle, &adev))
> + if (!adev)
> return 0;
>
> /* check for LID ACPI switch */
> @@ -159,7 +158,7 @@ static int s3_wmi_check_platform_device(
> strlen(SPI_CTL_OBJ_NAME)))
> return 0;
>
> - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,
> + status = acpi_walk_namespace(ACPI_TYPE_DEVICE, adev->handle, 1,
> s3_wmi_attach_spi_device, NULL,
> &ts_adev, NULL);
> if (ACPI_FAILURE(status))
>
>
>