From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chen Yu <yu.c.chen@intel.com>
Cc: linux-acpi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
Ashok Raj <ashok.raj@intel.com>, Mike Rapoport <rppt@kernel.org>,
Aubrey Li <aubrey.li@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/4] drivers/acpi: Introduce Platform Firmware Runtime Update Telemetry
Date: Mon, 1 Nov 2021 13:23:22 +0200 [thread overview]
Message-ID: <YX/OKs8j1weqwomr@smile.fi.intel.com> (raw)
In-Reply-To: <20211101101641.GA20219@chenyu5-mobl1>
On Mon, Nov 01, 2021 at 06:16:41PM +0800, Chen Yu wrote:
> On Wed, Oct 27, 2021 at 01:45:00PM +0300, Andy Shevchenko wrote:
> > On Wed, Oct 27, 2021 at 03:08:05PM +0800, Chen Yu wrote:
...
> > Looking into the code I have feelings of déjà-vu. Has it really had
> > nothing in common with the previous patch?
> >
> They both invokes _DSM to trigger the low level actions. However the input
> parameters and return ACPI package as well as the functions are different
> and hard to extract the common code between them.
So, please amend commit message(s) to elaborate this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-01 11:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 7:06 [PATCH v7 0/4] Introduce Platform Firmware Runtime Update and Telemetry drivers Chen Yu
2021-10-27 7:07 ` [PATCH v7 1/4] efi: Introduce EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and corresponding structures Chen Yu
2021-10-27 10:00 ` Andy Shevchenko
2021-11-01 11:01 ` Chen Yu
2021-10-27 7:07 ` [PATCH v7 2/4] drivers/acpi: Introduce Platform Firmware Runtime Update device driver Chen Yu
2021-10-27 7:22 ` Greg Kroah-Hartman
2021-11-01 7:54 ` Chen Yu
2021-10-27 10:20 ` Andy Shevchenko
2021-11-01 9:33 ` Chen Yu
2021-11-01 11:21 ` Andy Shevchenko
2021-11-01 13:14 ` Chen Yu
2021-11-01 13:16 ` Greg Kroah-Hartman
2021-11-01 14:08 ` Andy Shevchenko
2021-11-01 14:57 ` Chen Yu
2021-11-01 15:02 ` Andy Shevchenko
2021-10-27 7:08 ` [PATCH v7 3/4] drivers/acpi: Introduce Platform Firmware Runtime Update Telemetry Chen Yu
2021-10-27 10:45 ` Andy Shevchenko
2021-11-01 10:16 ` Chen Yu
2021-11-01 11:23 ` Andy Shevchenko [this message]
2021-10-27 7:08 ` [PATCH v7 4/4] tools: Introduce power/acpi/pfru/pfru Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX/OKs8j1weqwomr@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ardb@kernel.org \
--cc=ashok.raj@intel.com \
--cc=aubrey.li@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox