From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50876C433F5 for ; Wed, 10 Nov 2021 08:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C2116112F for ; Wed, 10 Nov 2021 08:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbhKJIJS (ORCPT ); Wed, 10 Nov 2021 03:09:18 -0500 Received: from mga14.intel.com ([192.55.52.115]:23527 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbhKJIJQ (ORCPT ); Wed, 10 Nov 2021 03:09:16 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="232867174" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="232867174" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 00:06:29 -0800 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="564338585" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 00:06:27 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id A69D1205BA; Wed, 10 Nov 2021 10:06:25 +0200 (EET) Date: Wed, 10 Nov 2021 10:06:25 +0200 From: Sakari Ailus To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, John Ogness , rafael@kernel.org, mika.westerberg@linux.intel.com, Petr Mladek Subject: Re: [PATCH 2/2] ACPI: Make acpi_node_get_parent() local Message-ID: References: <20211109111935.1627406-1-sakari.ailus@linux.intel.com> <20211109111935.1627406-3-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Nov 09, 2021 at 02:20:37PM +0200, Andy Shevchenko wrote: > On Tue, Nov 09, 2021 at 01:19:35PM +0200, Sakari Ailus wrote: > > acpi_node_get_parent() isn't used outside drivers/acpi/property.c. Make it > > local. > > > > Signed-off-by: Sakari Ailus > > > Reviewed-by: Andy Shevchenko > > Please, change this to @linux.intel.com. > > ... > > > - struct device *dev = > > - to_acpi_device_node(fwnode)->dev.parent; > > + struct device *dev = to_acpi_device_node(fwnode)->dev.parent; > > Ping-pong? (see comment to the previous patch) This was meant to be in the first patch, I'll send v3. -- Sakari Ailus