From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org,
John Ogness <john.ogness@linutronix.de>,
rafael@kernel.org, mika.westerberg@linux.intel.com,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH 1/2] ACPI: Get acpi_device's parent from the parent field
Date: Wed, 10 Nov 2021 10:18:20 +0200 [thread overview]
Message-ID: <YYuATCA2yyCFBFN5@smile.fi.intel.com> (raw)
In-Reply-To: <YYt+IDubi6ib/Iko@paasikivi.fi.intel.com>
On Wed, Nov 10, 2021 at 10:09:04AM +0200, Sakari Ailus wrote:
> On Tue, Nov 09, 2021 at 02:19:13PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 09, 2021 at 01:19:34PM +0200, Sakari Ailus wrote:
...
> > > - } else if (is_acpi_device_node(fwnode)) {
> > > + }
> >
> > > + if (is_acpi_device_node(fwnode)) {
> >
> > Unneeded change. Yes I know that 'else' here can be skipped. But in such cases
> > it's a trade-off between changes, code readability and maintenance. Since here
> > it's a fix, backporting concerns are also play role.
>
> The patch applies cleanly to 5.5, the oldest kernel where it's needed.
Why? I don't see how this affects the workflow.
> Do you prefer another patch to remove the else clause?
Nope.
> I think it's a bit overkill...
Exactly, that's why the question is why have you split the if-else-if to two if:s?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-10 8:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 11:19 [PATCH 0/2] Get device's parent from parent field, fix sleeping IRQs disabled Sakari Ailus
2021-11-09 11:19 ` [PATCH 1/2] ACPI: Get acpi_device's parent from the parent field Sakari Ailus
2021-11-09 12:19 ` Andy Shevchenko
2021-11-10 8:09 ` Sakari Ailus
2021-11-10 8:18 ` Andy Shevchenko [this message]
2021-11-10 8:21 ` Sakari Ailus
2021-11-10 8:56 ` Andy Shevchenko
2021-11-10 12:02 ` Sakari Ailus
2021-11-10 13:12 ` Andy Shevchenko
2021-11-17 14:52 ` Rafael J. Wysocki
2021-11-17 16:46 ` Sakari Ailus
2021-11-09 11:19 ` [PATCH 2/2] ACPI: Make acpi_node_get_parent() local Sakari Ailus
2021-11-09 12:20 ` Andy Shevchenko
2021-11-10 8:06 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYuATCA2yyCFBFN5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox