From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D24CC433EF for ; Wed, 10 Nov 2021 08:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 200626117A for ; Wed, 10 Nov 2021 08:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbhKJIY1 (ORCPT ); Wed, 10 Nov 2021 03:24:27 -0500 Received: from mga12.intel.com ([192.55.52.136]:7756 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbhKJIY0 (ORCPT ); Wed, 10 Nov 2021 03:24:26 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="212651958" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="212651958" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 00:21:39 -0800 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="642462174" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 00:21:38 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 1B464205BA; Wed, 10 Nov 2021 10:21:36 +0200 (EET) Date: Wed, 10 Nov 2021 10:21:36 +0200 From: Sakari Ailus To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, John Ogness , rafael@kernel.org, mika.westerberg@linux.intel.com, Petr Mladek Subject: Re: [PATCH 1/2] ACPI: Get acpi_device's parent from the parent field Message-ID: References: <20211109111935.1627406-1-sakari.ailus@linux.intel.com> <20211109111935.1627406-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Nov 10, 2021 at 10:18:20AM +0200, Andy Shevchenko wrote: > On Wed, Nov 10, 2021 at 10:09:04AM +0200, Sakari Ailus wrote: > > On Tue, Nov 09, 2021 at 02:19:13PM +0200, Andy Shevchenko wrote: > > > On Tue, Nov 09, 2021 at 01:19:34PM +0200, Sakari Ailus wrote: > > ... > > > > > - } else if (is_acpi_device_node(fwnode)) { > > > > + } > > > > > > > + if (is_acpi_device_node(fwnode)) { > > > > > > Unneeded change. Yes I know that 'else' here can be skipped. But in such cases > > > it's a trade-off between changes, code readability and maintenance. Since here > > > it's a fix, backporting concerns are also play role. > > > > The patch applies cleanly to 5.5, the oldest kernel where it's needed. > > Why? I don't see how this affects the workflow. > > > Do you prefer another patch to remove the else clause? > > Nope. > > > I think it's a bit overkill... > > Exactly, that's why the question is why have you split the if-else-if to > two if:s? The else clause is useless, I think the code simply looks better without it. -- Sakari Ailus