Re: [PATCH] ACPI / x86: Revert: Make PWM2 device always present at Lenovo Yoga Book

[Yauhen Kharuzhy <jekhor@gmail.com>]

On Sat, Nov 13, 2021 at 02:52:06PM +0100, Hans de Goede wrote:
> It turns out that there is a WMI object which controls the PWM2 device
> used for the keyboard backlight and that WMI object also provides some
> other useful functionality.
> 
> The upcoming lenovo-yogabook-wmi driver will offer both backlight
> control and the other functionality, so there no longer is a need
> to have the lpss-pwm driver binding to PWM2 for backlight control;
> and this is now actually undesirable because this will cause both
> the WMI code and the lpss-pwm driver to poke at the same PWM
> controller.

Acked-by: Yauhen Kharuzhy <jekhor@gmail.com>

> 
> Revert commit ff6cdfd71495 ("ACPI / x86: Make PWM2 device always present
> at Lenovo Yoga Book"), removing the always-present quirk for the PWM2
> ACPI-device, so that the lpss-pwm controller will no longer bind to it.
> 
> Cc: Yauhen Kharuzhy <jekhor@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/acpi/x86/utils.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index cb988f9b23a1..bfcb76888ca7 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -54,10 +54,6 @@ static const struct always_present_id always_present_ids[] = {
>  	ENTRY("80860F09", "1", X86_MATCH(ATOM_SILVERMONT), {}),
>  	ENTRY("80862288", "1", X86_MATCH(ATOM_AIRMONT), {}),
>  
> -	/* Lenovo Yoga Book uses PWM2 for keyboard backlight control */
> -	ENTRY("80862289", "2", X86_MATCH(ATOM_AIRMONT), {
> -			DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> -		}),
>  	/* The Xiaomi Mi Pad 2 uses PWM2 for touchkeys backlight control */
>  	ENTRY("80862289", "2", X86_MATCH(ATOM_AIRMONT), {
>  		DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"),
> -- 
> 2.31.1
> 

-- 
Yauhen Kharuzhy