From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, heikki.krogerus@linux.intel.com,
rafael@kernel.org,
/tmp/small/0000-cover-letter.patch@punajuuri.localdomain
Subject: Re: [PATCH 7/7] device property: Drop fwnode_graph_get_remote_node()
Date: Tue, 30 Nov 2021 18:05:29 +0200 [thread overview]
Message-ID: <YaZLydKDBV9w+ve5@smile.fi.intel.com> (raw)
In-Reply-To: <20211130153250.935726-7-sakari.ailus@linux.intel.com>
On Tue, Nov 30, 2021 at 05:32:50PM +0200, Sakari Ailus wrote:
> fwnode_graph_get_remote_node() is only used by the tegra-video driver.
> Convert it to use newer fwnode_graph_get_endpoint_by_id() and drop
> now-unused fwnode_graph_get_remote_node().
...
> - remote = fwnode_graph_get_remote_node(fwnode, chan->portnos[0],
> - 0);
> - if (!remote)
> + struct fwnode_handle *ep, *remote;
> +
> + ep = fwnode_graph_get_endpoint_by_id(fwnode,
> + chan->portnos[0], 0, 0);
What makes you to move portnos to the next line? It's pretty much under 80.
> + if (!ep)
> continue;
>
> + remote = fwnode_graph_get_remote_port_parent(ep);
> + fwnode_handle_put(ep);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-30 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:32 [PATCH 1/7] device property: Fix fwnode_graph_devcon_match() fwnode leak Sakari Ailus
2021-11-30 15:32 ` [PATCH 2/7] device property: Fix documentation for FWNODE_GRAPH_DEVICE_DISABLED Sakari Ailus
2021-11-30 15:32 ` [PATCH 3/7] Documentation: ACPI: Fix data node reference documentation Sakari Ailus
2021-11-30 15:55 ` Andy Shevchenko
2021-11-30 20:42 ` Sakari Ailus
2021-11-30 20:50 ` Rafael J. Wysocki
2021-11-30 15:32 ` [PATCH 4/7] Documentation: ACPI: Update references Sakari Ailus
2021-11-30 15:57 ` Andy Shevchenko
2021-11-30 15:32 ` [PATCH 5/7] device property: Implement fwnode_graph_get_endpoint_count() Sakari Ailus
2021-11-30 16:01 ` Andy Shevchenko
2021-11-30 15:32 ` [PATCH 6/7] device property: Use fwnode_graph_for_each_endpoint() macro Sakari Ailus
2021-11-30 15:32 ` [PATCH 7/7] device property: Drop fwnode_graph_get_remote_node() Sakari Ailus
2021-11-30 16:05 ` Andy Shevchenko [this message]
2021-11-30 20:40 ` Sakari Ailus
2021-11-30 16:07 ` [PATCH 1/7] device property: Fix fwnode_graph_devcon_match() fwnode leak Andy Shevchenko
2021-11-30 20:21 ` Sakari Ailus
2021-12-01 13:19 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZLydKDBV9w+ve5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=/tmp/small/0000-cover-letter.patch@punajuuri.localdomain \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox