Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused

Andy Shevchenko
2021-11-26T17:46:27Z

On Thu, Nov 18, 2021 at 01:26:28PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 18, 2021 at 11:56:48AM +0100, Hans de Goede wrote:
> > Offset/pin 0 is a perfectly valid offset, so stop using it to have
> > the special meaning of interrupt line not used in the intr_lines.
> >
> > Instead introduce a new special INTR_LINE_UNUSED value which is never
> > a valid offset and use that to indicate unused interrupt lines.
>
> ...
>
> > +#define INTR_LINE_UNUSED U32_MAX
>
> Funny, I have had something similar in my local branch for a few years ;-)
>
> +#define CHV_INVALID_HWIRQ ((unsigned int)INVALID_HWIRQ)

I will rename this when applying. I assume there is no objection on doing it.