From: Wolfram Sang <wsa@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com,
christian.koenig@amd.com, digetx@gmail.com,
gregkh@linuxfoundation.org, jonathanh@nvidia.com,
ldewangan@nvidia.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
rafael@kernel.org, sumit.semwal@linaro.org,
thierry.reding@gmail.com
Subject: Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of of_*()
Date: Thu, 27 Jan 2022 22:57:25 +0100 [thread overview]
Message-ID: <YfMVRasTSQrr1ob+@shikoro> (raw)
In-Reply-To: <1642851166-27096-4-git-send-email-akhilrajeev@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Hi,
> + irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
> + "smbus_alert");
I think we should include "linux/property.h" for it. Interesting, the of
header was never included.
> - irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> + irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
> + "smbus_alert");
Here we should replace of_irq.h with property.h.
Rest looks good!
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-27 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 11:32 [PATCH v4 0/3] Enable named interrupt smbus-alert for ACPI Akhil R
2022-01-22 11:32 ` [PATCH v4 1/3] device property: Add fwnode_irq_get_byname Akhil R
2022-01-25 17:52 ` Rafael J. Wysocki
2022-01-22 11:32 ` [PATCH v4 2/3] docs: firmware-guide: ACPI: Add named interrupt doc Akhil R
2022-01-25 17:54 ` Rafael J. Wysocki
2022-01-22 11:32 ` [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of of_*() Akhil R
2022-01-27 21:57 ` Wolfram Sang [this message]
2022-01-22 12:05 ` [PATCH v4 0/3] Enable named interrupt smbus-alert for ACPI Andy Shevchenko
2022-01-24 18:50 ` Rafael J. Wysocki
2022-01-24 21:04 ` Wolfram Sang
2022-01-25 17:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfMVRasTSQrr1ob+@shikoro \
--to=wsa@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=christian.koenig@amd.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).