Re: [PATCH 0/4] Shovel firmware specific code to appropriate locations

Andy Shevchenko
2022-02-07T13:25:49Z

On Sun, Feb 06, 2022 at 11:16:39AM +0200, Sakari Ailus wrote:
> Hi folks,
>
> This set moves the implementation of recently added device property API
> functions to OF and ACPI frameworks, where the rest of such functionality
> resides.
>
> Compile tested.

All look good to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Note that after some initial confusion, this set actually does depend on
> Andy's patch "device property: Don't split fwnode_get_irq*() APIs in the
> code" to appear in the linux-acpi tree.

Perhaps than you can add to your series the conversion of
fwnode_irq_get_byname()?

> Sakari Ailus (4):
> device property: Convert device_{dma_supported,get_dma_attr} to fwnode
> ACPI: property: Move acpi_fwnode_device_get_match_data() up
> device property: Add iomap to fwnode operations
> device property: Add irq_get to fwnode operation
>
> drivers/acpi/property.c | 36 +++++++++++++++++++++++++++++++----
> drivers/base/property.c | 42 ++++++-----------------------------------
> drivers/of/property.c | 31 ++++++++++++++++++++++++++++++
> include/linux/fwnode.h | 5 +++++
> 4 files changed, 74 insertions(+), 40 deletions(-)
>
> --
> 2.30.2
>
>

--
With Best Regards,
Andy Shevchenko