Re: [PATCH 0/4] Shovel firmware specific code to appropriate locations

Sakari Ailus
2022-02-07T15:05:34Z

Hi Andy,

On Mon, Feb 07, 2022 at 02:27:43PM +0200, Andy Shevchenko wrote:
> On Sun, Feb 06, 2022 at 11:16:39AM +0200, Sakari Ailus wrote:
> > Hi folks,
> >
> > This set moves the implementation of recently added device property API
> > functions to OF and ACPI frameworks, where the rest of such functionality
> > resides.
> >
> > Compile tested.
>
> All look good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks!

> > Note that after some initial confusion, this set actually does depend on
> > Andy's patch "device property: Don't split fwnode_get_irq*() APIs in the
> > code" to appear in the linux-acpi tree.
>
> Perhaps than you can add to your series the conversion of
> fwnode_irq_get_byname()?

It relies on other fwnode functions to do its job so there's nothing to fix
there.

--
Kind regards,

Sakari Ailus