Re: [PATCH 1/4] device property: Convert device_{dma_supported,get_dma_attr} to fwnode

Sakari Ailus
2022-02-14T13:31:39Z

Hi Rob,

On Fri, Feb 11, 2022 at 09:55:22AM -0600, Rob Herring wrote:
> On Sun, Feb 06, 2022 at 11:16:40AM +0200, Sakari Ailus wrote:
> > Make the device_dma_supported and device_get_dma_attr functions to use the
> > fwnode ops, and move the implementation to ACPI and OF frameworks.
> >
> > Depends-on: ("device property: Don't split fwnode_get_irq*() APIs in the code")
>
> Is this some new convention? What's wrong with 'base-commit' and
> shouldn't it be below the '---'?

I guess that could be possible, too. There are different practices it
seems.

I'll add commit id in v2 (or drop the tag if the dependent patch hits the
linux-acpi tree soonish).

>
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > drivers/acpi/property.c | 14 ++++++++++++++
> > drivers/base/property.c | 25 ++++---------------------
> > drivers/of/property.c | 17 +++++++++++++++++
> > include/linux/fwnode.h | 3 +++
> > 4 files changed, 38 insertions(+), 21 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>

Thanks!

--
Sakari Ailus