From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Xiaomeng.Hou@amd.com,
Aaron.Liu@amd.com, Ray.Huang@amd.com, hdegoede@redhat.com
Subject: Re: [PATCH v2 2/3] ACPI: bus: Allow negotiating OSC capabilities
Date: Mon, 28 Feb 2022 19:06:11 +0200 [thread overview]
Message-ID: <Yh0BA/JUInoQYaYq@lahna> (raw)
In-Reply-To: <20220225055224.190669-2-mario.limonciello@amd.com>
On Thu, Feb 24, 2022 at 11:52:23PM -0600, Mario Limonciello wrote:
> Currently when capabilities have been masked by firmware during a
> negotiation with OSC_QUERY_ENABLE set they're silently ignored
> by the caller. If the caller calls `acpi_run_osc` again without
> query set and the same capabilities, then they instead get a failure
> possibly leading to downstream problems.
>
> So instead when query is set return AE_SUPPORT which callers can then
> use for determining that capabilities were masked.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2022-02-28 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 5:52 [PATCH v2 1/3] ACPI: APEI: Adjust for acpi_run_osc logic changes Mario Limonciello
2022-02-25 5:52 ` [PATCH v2 2/3] ACPI: bus: Allow negotiating OSC capabilities Mario Limonciello
2022-02-28 17:06 ` Mika Westerberg [this message]
2022-02-25 5:52 ` [PATCH v2 3/3] ACPI: bus: For platform OSC negotiate capabilities Mario Limonciello
2022-02-28 17:11 ` Mika Westerberg
2022-02-28 14:46 ` [PATCH v2 1/3] ACPI: APEI: Adjust for acpi_run_osc logic changes Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh0BA/JUInoQYaYq@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Aaron.Liu@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaomeng.Hou@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox