From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162D4C433F5 for ; Wed, 13 Apr 2022 18:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236138AbiDMSZd (ORCPT ); Wed, 13 Apr 2022 14:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232456AbiDMSZd (ORCPT ); Wed, 13 Apr 2022 14:25:33 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E86339B93; Wed, 13 Apr 2022 11:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649874191; x=1681410191; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/+xMj+IKFmTxJpJGVNQWc4V5J5OA4f1IEmIa7d8H4Mk=; b=Qim5kBZ+UE2k4hXTa7QQQvpMULUMqdIYQS7JSDAtZILlJZXSPM+Rm0b4 Wno8wbx7SgU/W+8ZDqbByzByZLWM0XhCsoq587dLXOaZrPpGEGQceyK8u zDrXHid8FbAde+yh05iIdQZzuMV4KuWhn8apSAzchTBn6c1LV34w/H5TH jQWpj5HPGWErzv7mPIkjv3Iat5RklaaqpBd/rEPiuYc9PVk6/6WPPc1gG AAcRr0E/H6Z0b20Z4xTdKp6dcrDybOYhMGLI3MOMYP3fJF1WFeiVfUxNt c1f5pj5Eg8ebStgl0cEFjfY8cPxefAKUKCSXScL3e6KYkGNU71I7t7smb A==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="261588079" X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="261588079" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 11:23:10 -0700 X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="661034729" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 11:23:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nehaS-001xbd-Qr; Wed, 13 Apr 2022 21:19:28 +0300 Date: Wed, 13 Apr 2022 21:19:28 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Rob Herring , ACPI Devel Maling List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Frank Rowand , Len Brown Subject: Re: [PATCH v6 4/5] device property: Constify fwnode_handle_get() Message-ID: References: <20220408184844.22829-1-andriy.shevchenko@linux.intel.com> <20220408184844.22829-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Apr 13, 2022 at 08:10:22PM +0200, Rafael J. Wysocki wrote: > On Fri, Apr 8, 2022 at 8:49 PM Andy Shevchenko > wrote: ... > > -struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode) > > +struct fwnode_handle *fwnode_handle_get(const struct fwnode_handle *fwnode) > > { > > if (!fwnode_has_op(fwnode, get)) > > return fwnode; ^^^^, so it needs a casting, but then we have to comment why is so. > Why is 0-day complaining about this one? -- With Best Regards, Andy Shevchenko