From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Aubrey Li <aubrey.li@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write()
Date: Thu, 28 Apr 2022 13:29:07 +0300 [thread overview]
Message-ID: <Ympsc5PG9YRZmJzG@smile.fi.intel.com> (raw)
In-Reply-To: <20220428062430.31010-2-paul.gortmaker@windriver.com>
On Thu, Apr 28, 2022 at 02:24:27AM -0400, Paul Gortmaker wrote:
> This function isn't used anywhere in the driver or anywhere in tree.
> So remove it. It can always be re-added if/when a use arises.
Can we first move the driver under intel subfolder and then update?
I have no strong opinion, but personally I would keep it (even unexported) just
for the sake of consistency. Up to Mark and Hans.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-28 10:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 6:24 [PATCH 0/4] platform: allow ATOM PMC code to be optional Paul Gortmaker
2022-04-28 6:24 ` [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write() Paul Gortmaker
2022-04-28 10:29 ` Andy Shevchenko [this message]
2022-05-06 10:43 ` Hans de Goede
2022-04-28 6:24 ` [PATCH 2/4] ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit Paul Gortmaker
2022-04-28 10:35 ` Andy Shevchenko
2022-05-05 19:03 ` Rafael J. Wysocki
2022-04-28 6:24 ` [PATCH 3/4] platform/x86: pmc_atom: dont export pmc_atom_read - no modular users Paul Gortmaker
2022-05-06 10:43 ` Hans de Goede
2022-04-28 6:24 ` [PATCH 4/4] platform/x86: pmc_atom: make the PMC driver actually unselectable Paul Gortmaker
2022-04-28 10:20 ` Andy Shevchenko
2022-05-02 14:45 ` Hans de Goede
2022-04-28 10:12 ` [PATCH 0/4] platform: allow ATOM PMC code to be optional Andy Shevchenko
2022-04-28 18:11 ` Paul Gortmaker
2022-04-29 12:34 ` Andy Shevchenko
2022-05-02 14:30 ` Hans de Goede
2022-05-02 16:05 ` Andy Shevchenko
2022-05-03 7:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ympsc5PG9YRZmJzG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox