From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F00C433F5 for ; Thu, 28 Apr 2022 10:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234930AbiD1Kc2 (ORCPT ); Thu, 28 Apr 2022 06:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234079AbiD1Kc1 (ORCPT ); Thu, 28 Apr 2022 06:32:27 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 994B653E17; Thu, 28 Apr 2022 03:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651141753; x=1682677753; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GFRbWkn3PBPqGL9xwfna2VQj3DYDSKswtXSwu8Tf1Gk=; b=ZcxI4eFUw1mPhSL1hSx2KxGaNWbRHxcuiHkLiIv+nNVsEtaAaODezbJv RReahfeQbwuTA/rCsy3km8xibf2KHHiQhHGqSF4/K1UCHqIKy/MTU2qK/ vUPzo65fdc5zvPWpVgmHysP+LmnNNotDx9IssfAGPe6H2HgpMbqLpdYqs /aRU66oWCayMd9ZrKJS70O5OY8jjaOhBiHeWKI/CpDqTPpQHlyCRBqGnv wLxByIsRDlP9bH9R8SgJGwfU5lRkW9gFFVRULZVnS0rTKqj0Lg1iCny6Z EqHLs4oxws+V7Zat+6hkQbr7PDEswNO5fSNRIgF0OH449IUudeNXMaxeI w==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="246156437" X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="246156437" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 03:29:13 -0700 X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="596729808" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 03:29:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nk1OV-009Fbx-Cm; Thu, 28 Apr 2022 13:29:07 +0300 Date: Thu, 28 Apr 2022 13:29:07 +0300 From: Andy Shevchenko To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Aubrey Li , Hans de Goede , Len Brown , linux-acpi@vger.kernel.org, Mark Gross , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write() Message-ID: References: <20220428062430.31010-1-paul.gortmaker@windriver.com> <20220428062430.31010-2-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220428062430.31010-2-paul.gortmaker@windriver.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Apr 28, 2022 at 02:24:27AM -0400, Paul Gortmaker wrote: > This function isn't used anywhere in the driver or anywhere in tree. > So remove it. It can always be re-added if/when a use arises. Can we first move the driver under intel subfolder and then update? I have no strong opinion, but personally I would keep it (even unexported) just for the sake of consistency. Up to Mark and Hans. -- With Best Regards, Andy Shevchenko