From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v3 3/8] ACPI: property: Use acpi_object_type consistently in property ref parsing
Date: Wed, 25 May 2022 20:23:45 +0300 [thread overview]
Message-ID: <Yo5mIZxz8HDtxRPP@smile.fi.intel.com> (raw)
In-Reply-To: <20220525130123.767410-4-sakari.ailus@linux.intel.com>
On Wed, May 25, 2022 at 04:01:18PM +0300, Sakari Ailus wrote:
> The type of union acpi_object field type is acpi_object_type. Use that
> instead of int.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/acpi/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index f8c83ee6c8d59..b36cb7e36e420 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -793,7 +793,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
> * nor integer, return an error, we can't parse it.
> */
> for (i = 0; element + i < end && i < num_args; i++) {
> - int type = element[i].type;
> + acpi_object_type type = element[i].type;
>
> if (type == ACPI_TYPE_LOCAL_REFERENCE)
> break;
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-25 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 13:01 [PATCH v3 0/8] ACPI: Buffer property and reference as string support Sakari Ailus
2022-05-25 13:01 ` [PATCH v3 1/8] ACPI: property: Return type of acpi_add_nondev_subnodes() should be bool Sakari Ailus
2022-05-25 17:15 ` Andy Shevchenko
2022-05-25 13:01 ` [PATCH v3 2/8] ACPI: property: Tie data nodes to acpi handles Sakari Ailus
2022-05-25 17:20 ` Andy Shevchenko
2022-05-27 14:35 ` Sakari Ailus
2022-05-26 19:19 ` Rafael J. Wysocki
2022-05-27 9:02 ` Sakari Ailus
2022-05-27 17:04 ` Rafael J. Wysocki
2022-05-27 20:59 ` Sakari Ailus
2022-05-28 13:56 ` Rafael J. Wysocki
2022-05-25 13:01 ` [PATCH v3 3/8] ACPI: property: Use acpi_object_type consistently in property ref parsing Sakari Ailus
2022-05-25 17:23 ` Andy Shevchenko [this message]
2022-05-25 13:01 ` [PATCH v3 4/8] ACPI: property: Move property ref argument parsing into a new function Sakari Ailus
2022-05-25 17:28 ` Andy Shevchenko
2022-05-27 14:37 ` Sakari Ailus
2022-05-25 13:01 ` [PATCH v3 5/8] ACPI: property: Switch node property referencing from ifs to a switch Sakari Ailus
2022-05-25 17:30 ` Andy Shevchenko
2022-05-25 13:01 ` [PATCH v3 6/8] ACPI: property: Unify integer value reading functions Sakari Ailus
2022-05-25 17:14 ` Andy Shevchenko
2022-05-27 15:12 ` Sakari Ailus
2022-05-25 13:01 ` [PATCH v3 7/8] ACPI: property: Add support for parsing buffer property UUID Sakari Ailus
2022-05-25 17:44 ` Andy Shevchenko
2022-05-27 12:43 ` Sakari Ailus
2022-05-25 13:01 ` [PATCH v3 8/8] ACPI: property: Read buffer properties as integers Sakari Ailus
2022-05-25 17:36 ` Andy Shevchenko
2022-05-27 10:01 ` Sakari Ailus
2022-06-09 18:38 ` [PATCH v3 0/8] ACPI: Buffer property and reference as string support Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo5mIZxz8HDtxRPP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox