From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v2 7/8] ACPI: property: Add support for parsing buffer property UUID
Date: Fri, 20 May 2022 17:28:52 +0300 [thread overview]
Message-ID: <YoelpPVmLoKL295p@smile.fi.intel.com> (raw)
In-Reply-To: <20220520061148.21366-8-sakari.ailus@linux.intel.com>
On Fri, May 20, 2022 at 09:11:47AM +0300, Sakari Ailus wrote:
> Add support for newly added buffer property UUID, as defined in the DSD
> guide.
...
> static bool acpi_enumerate_nondev_subnodes(acpi_handle scope,
> - const union acpi_object *desc,
> + union acpi_object *desc,
> struct acpi_device_data *data,
> struct fwnode_handle *parent);
> -static bool acpi_extract_properties(const union acpi_object *desc,
> +static bool acpi_extract_properties(acpi_handle handle,
> + union acpi_object *desc,
> struct acpi_device_data *data);
Looking at the first one, can union member be const in the last one?
...
> struct acpi_device_properties {
> const guid_t *guid;
> - const union acpi_object *properties;
> + union acpi_object *properties;
Probably this change explains on the above question...
> struct list_head list;
> + void **bufs;
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-20 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 6:11 [PATCH v2 0/8] ACPI: Buffer property and reference as string support Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 1/8] ACPI: property: Return type of acpi_add_nondev_subnodes() should be bool Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 2/8] ACPI: property: Tie data nodes to acpi handles Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 3/8] ACPI: property: Use acpi_object_type consistently in property ref parsing Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 4/8] ACPI: property: Move property ref argument parsing into a new function Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 5/8] ACPI: property: Switch node property referencing from ifs to a switch Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 6/8] ACPI: property: Unify integer value reading functions Sakari Ailus
2022-05-20 14:25 ` Andy Shevchenko
2022-05-20 22:04 ` Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 7/8] ACPI: property: Add support for parsing buffer property UUID Sakari Ailus
2022-05-20 14:28 ` Andy Shevchenko [this message]
2022-05-25 8:13 ` Sakari Ailus
2022-05-20 6:11 ` [PATCH v2 8/8] ACPI: property: Read buffer properties as integers Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoelpPVmLoKL295p@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox