Re: [PATCH 1/2] x86: notify hypervisor about guest entering s2idle state

Sean Christopherson
2022-06-16T16:53:38Z

On Wed, Jun 15, 2022, Grzegorz Jaszczyk wrote:
> pt., 10 cze 2022 o 16:30 Sean Christopherson <seanjc@google.com> napisał(a):
> > MMIO or PIO for the actual exit, there's nothing special about hypercalls. As for
> > enumerating to the guest that it should do something, why not add a new ACPI_LPS0_*
> > function? E.g. something like
> >
> > static void s2idle_hypervisor_notify(void)
> > {
> > if (lps0_dsm_func_mask > 0)
> > acpi_sleep_run_lps0_dsm(ACPI_LPS0_EXIT_HYPERVISOR_NOTIFY
> > lps0_dsm_func_mask, lps0_dsm_guid);
> > }
>
> Great, thank you for your suggestion! I will try this approach and
> come back. Since this will be the main change in the next version,
> will it be ok for you to add Suggested-by: Sean Christopherson
> <seanjc@google.com> tag?

If you want, but there's certainly no need to do so. But I assume you or someone
at Intel will need to get formal approval for adding another ACPI LPS0 function?
I.e. isn't there work to be done outside of the kernel before any patches can be
merged?