From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145FFC433EF for ; Fri, 1 Jul 2022 05:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232223AbiGAFss (ORCPT ); Fri, 1 Jul 2022 01:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231426AbiGAFsr (ORCPT ); Fri, 1 Jul 2022 01:48:47 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDED6B260; Thu, 30 Jun 2022 22:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656654527; x=1688190527; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=y5ug2lyRKciQTK4LIaK6tpSgjuLHRuKAtCuP90hqIAY=; b=Yk2yocUeVh4/v7hL72iZ3LS4sqXqto/M7DNFRPeXeKKoolhRW63KTAfV 2DVXtIZrFp5mkhODN+E50BejC1pMvPkrOhoHesuGckpvxRNkj3/b9V+1x yDKGnJIwtZh5IPrVJxRamHW0s3aMcsaZgIB1J04odwszAzjX+ajYUpzwH FAeZOMttIZlIfDI1B1A8BRfPpO/J6ymjqtJ5c155Dz0kvCt+uLGZsh3tK L2EGDxabBl9fGoVMGc0foQw9ypqvbHRvm1TDIztwZGVyf/5PpqYsyfdLL ySIGbMHYAfICCS05oOuW6YMl89PRY/EuSp+BooPbzk3P2W99X/y8288xl g==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="282590975" X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="282590975" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 22:48:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="733930884" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 22:48:43 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 01 Jul 2022 08:48:40 +0300 Date: Fri, 1 Jul 2022 08:48:40 +0300 From: Mika Westerberg To: Mario Limonciello Cc: "Rafael J. Wysocki" , Len Brown , Huang Rui , perry.yuan@amd.com, CUI Hao , maxim.novozhilov@gmail.com, lethe.tree@protonmail.com, garystephenwright@gmail.com, galaxyking0419@gmail.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] ACPI: CPPC: Only probe for _CPC if CPPC v2 is acked Message-ID: References: <20220701022529.2134-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701022529.2134-1-mario.limonciello@amd.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jun 30, 2022 at 09:25:27PM -0500, Mario Limonciello wrote: > Previously the kernel used to ignore whether the firmware masked CPPC > or CPPCv2 and would just pretend that it worked. > > When support for the USB4 bit in _OSC was introduced from commit > 9e1f561afb ("ACPI: Execute platform _OSC also with query bit clear") > the kernel began to look at the return when the query bit was clear. > > This caused regressions that were misdiagnosed and attempted to be solved > as part of commit 2ca8e6285250 ("Revert "ACPI: Pass the same capabilities > to the _OSC regardless of the query flag""). This caused a different > regression where non-Intel systems weren't able to negotiate _OSC > properly. > > This was reverted in commit 2ca8e6285250 ("Revert "ACPI: Pass the same > capabilities to the _OSC regardless of the query flag"") and attempted to > be fixed by commit c42fa24b4475 ("ACPI: bus: Avoid using CPPC if not > supported by firmware") but the regression still returned. > > These systems with the regression only load support for CPPC from an SSDT > dynamically when _OSC reports CPPC v2. Avoid the problem by not letting > CPPC satisfy the requirement in `acpi_cppc_processor_probe`. > > Reported-by: CUI Hao > Reported-by: maxim.novozhilov@gmail.com > Reported-by: lethe.tree@protonmail.com > Reported-by: garystephenwright@gmail.com > Reported-by: galaxyking0419@gmail.com > Fixes: c42fa24b4475 ("ACPI: bus: Avoid using CPPC if not supported by firmware") > Fixes: 2ca8e6285250 ("Revert "ACPI Pass the same capabilities to the _OSC regardless of the query flag"") > Link: https://bugzilla.kernel.org/show_bug.cgi?id=213023 > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2075387 > Signed-off-by: Mario Limonciello Reviewed-by: Mika Westerberg