From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AEDCCA47C for ; Wed, 13 Jul 2022 17:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbiGMRhs (ORCPT ); Wed, 13 Jul 2022 13:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbiGMRhs (ORCPT ); Wed, 13 Jul 2022 13:37:48 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A24BA2CCBA; Wed, 13 Jul 2022 10:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657733867; x=1689269867; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=jkI+8p3nzS5uhRs0bvgZsKIkyptdyJilhkJ4VnAOZB8=; b=nzW0QCVonDb0+aaSm1DsX6WCaoJ9VVj9wgH/r+h8U0Yr6Kn1U8pHDKVW c5mARU3sT4n0fwrilAqt1GLzQiQn+2O/qB9DZ33d+s3nmVGJiFO9/6wmV MKocvowpCoLTucPGyVwacSAFtP64VAe0F58UIMwsYMkrvjcyzgUgsxtuh 38rQqXhapmqTkVW5g7FogOqkH6EFMl3k9ToKEBKAFEcg19yHRUXmVYE4c O+FY/7wXZ1FCBGX2EHAasAJMv4x2Ur3kDwxBzz+f+y8YuG9Y0H3KdrfBc J+FuBCVbLsQL/gnLYwvYUWiCBy4/F2CXVbtBHiQZ8PCFJEA56ufNvaJ/N A==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="371609382" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="371609382" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 10:36:45 -0700 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="737966971" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 10:36:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oBgHv-001CZF-0z; Wed, 13 Jul 2022 20:36:39 +0300 Date: Wed, 13 Jul 2022 20:36:38 +0300 From: Andy Shevchenko To: Nuno =?iso-8859-1?Q?S=E1?= Cc: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Krzysztof Kozlowski , Bartosz Golaszewski , Frank Rowand , Mika Westerberg , Rob Herring , Linus Walleij Subject: Re: [PATCH 1/4] gpiolib: add support for bias pull disable Message-ID: References: <20220713131421.1527179-1-nuno.sa@analog.com> <20220713131421.1527179-2-nuno.sa@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220713131421.1527179-2-nuno.sa@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Jul 13, 2022 at 03:14:18PM +0200, Nuno Sá wrote: > This change prepares the gpio core to look at firmware flags and set > 'FLAG_BIAS_DISABLE' if necessary. It works in similar way to > 'GPIO_PULL_DOWN' and 'GPIO_PULL_UP'. ... > GPIO_PULL_UP = (1 << 4), > GPIO_PULL_DOWN = (1 << 5), > + GPIO_PULL_DISABLE = (1 << 6), To me it seems superfluous. You have already two flags: PUp PDown When none is set --> Pdisable -- With Best Regards, Andy Shevchenko