Re: [PATCH 0/4] add support for bias pull-disable

Nuno Sá
2022-07-18T10:45:15Z

On Mon, 2022-07-18 at 12:29 +0200, Linus Walleij wrote:
> On Mon, Jul 18, 2022 at 9:50 AM Nuno Sá <noname.nuno@gmail.com>
> wrote:
>
> > > right in that the character device is the only way to set this
> > > mode
> > > ATM and. However I would like to see the first user added
> > > together
> > > with the series because adding features nobody uses in the
> > > mainline
> > > kernel tree is generally frowned upon and it's also not clear
> > > that
> > > anyone actually wants to use it.
> >
> > Hmm, you mean something like a system's devicetree needing this
> > flag?
> > If so, I don't really have such a thing. I did all my testing on a
> > rpi
> > using overlays.
>
> I would assume a driver with a .set_config() responding to this flag?
>

Ahh if that is the case, then there are actually users of this flag
already.

"
git grep -lw "PIN_CONFIG_BIAS_DISABLE" drivers/gpio
drivers/gpio/gpio-aspeed.c
drivers/gpio/gpio-merrifield.c
drivers/gpio/gpio-omap.c
drivers/gpio/gpio-pca953x.c
"

This is also one of my arguments why I think having this new flag is
better than me adding a workaround for the device I'm supporting. Also,
in the cover I have a link to a new user (which is an input keyboard
driver that I'm refactoring) of this flag in .set_config().

- Nuno Sá