From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B64C25B06 for ; Tue, 9 Aug 2022 07:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239709AbiHIHk7 (ORCPT ); Tue, 9 Aug 2022 03:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239657AbiHIHk7 (ORCPT ); Tue, 9 Aug 2022 03:40:59 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25CD72AC5; Tue, 9 Aug 2022 00:40:58 -0700 (PDT) Received: from zn.tnic (p200300ea971b98cb329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:98cb:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B3A811EC02F2; Tue, 9 Aug 2022 09:40:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1660030852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JiahcPpB59A40BPkMd4ywQfXiGMzQEuPTAmeoaPvrR0=; b=AxCUusDkULZu1GoSEEuXeDN1rdPahnGEXVDoAdw9eTSQ47tyuwT++kQ5nfkdGbIhq42aQE ewF1uTytCojXGdWi4sfyCRwjv6ReBomKCE2nHg2ZzR4T6eaI6zJzu/w7Vg4+sXUn34RcjW XOYO62SiHhZuIyhR9/qdi3kmSc3UjBw= Date: Tue, 9 Aug 2022 09:40:47 +0200 From: Borislav Petkov To: "Kani, Toshi" Cc: "Rafael J. Wysocki" , Jia He , Len Brown , James Morse , Tony Luck , Mauro Carvalho Chehab , Robert Richter , Shuai Xue , Jarkko Sakkinen , ACPI Devel Maling List , Linux Kernel Mailing List , "open list:EDAC-CORE" Subject: Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register Message-ID: References: <20220805023200.154634-1-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Aug 08, 2022 at 09:36:13PM +0000, Kani, Toshi wrote: > Platforms with ACPI GHES support should use ghes_edac. This is the > case on Arm. The x86 side has additional platform ID check to protect > from legacy buggy GHES FW existed before ghes_edac enablement. Sounds to me like we should put all that logic in ghes.c and out of ghes_edac and the EDAC drivers will query it by doing upon load: _init: if (ghes_edac_driver_is_preferred()) return -ENODEV; And then ghes_edac can become a normal driver module again. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette