Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

Borislav Petkov
2022-08-08T18:37:54Z

+ Toshi.

On Mon, Aug 08, 2022 at 08:17:58PM +0200, Rafael J. Wysocki wrote:
> This effectively makes EDAC depend on GHES which may not be always
> valid AFAICS.

Yes, and this has been getting on my nerves since forever.

The GHES code which does collect all those errors *forces* the
registration of an EDAC module which does only the reporting.

Which cannot be any more backwards.

What should happen is, GHES inits and starts working on the errors.
Then, at some point later, ghes_edac loads and starts reporting whatever
it gets. If there's no EDAC module, it doesn't report them. The same way
MCA works.

That's it.

And then ghes_edac can be made a normal module again and we can get rid
of this insanity.

Jia, willing to try it?

Thx.

--
Regards/Gruss,
Boris.